GWicke has submitted this change and it was merged. Change subject: Minor code cleanup in round-trip.js ......................................................................
Minor code cleanup in round-trip.js * Eliminated common subexpressions to reduce code verbosity. * Fixed JSHint warning/error. * Moved myOuterHTML function definition out of a loop. * Replaced private JSDOM property accesses with public ones * Avoid using outerHTML for node type testing, use nodeType instead * Also use comments and their width information Change-Id: I508754d3cfad60306aa7f629a8d4401d444b2119 --- M js/tests/roundtrip-test.js 1 file changed, 51 insertions(+), 38 deletions(-) Approvals: GWicke: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32492 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I508754d3cfad60306aa7f629a8d4401d444b2119 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <[email protected]> Gerrit-Reviewer: GWicke <[email protected]> Gerrit-Reviewer: Subramanya Sastry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
