Hoo man has uploaded a new change for review. https://gerrit.wikimedia.org/r/188114
Change subject: From MediaWiki 1.24 on UnitTestsList can handle directories ...................................................................... From MediaWiki 1.24 on UnitTestsList can handle directories This was added in https://gerrit.wikimedia.org/r/163528 Change-Id: Ibd3a85751b2bb89df56889b0b0a4bcd6c98f41c7 --- M client/WikibaseClient.hooks.php M lib/WikibaseLib.hooks.php M repo/Wikibase.hooks.php 3 files changed, 3 insertions(+), 36 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/14/188114/1 diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php index b62627c..2bdeb97 100644 --- a/client/WikibaseClient.hooks.php +++ b/client/WikibaseClient.hooks.php @@ -78,18 +78,7 @@ */ public static function registerUnitTests( array &$files ) { // @codeCoverageIgnoreStart - $directoryIterator = new RecursiveDirectoryIterator( __DIR__ . '/tests/phpunit/' ); - - /** - * @var SplFileInfo $fileInfo - */ - foreach ( new RecursiveIteratorIterator( $directoryIterator ) as $fileInfo ) { - if ( substr( $fileInfo->getFilename(), -8 ) === 'Test.php' ) { - $files[] = $fileInfo->getPathname(); - } - } - - return true; + $files[] = __DIR__ . '/tests/phpunit/'; // @codeCoverageIgnoreEnd } diff --git a/lib/WikibaseLib.hooks.php b/lib/WikibaseLib.hooks.php index 73b1dd4..71c981a 100644 --- a/lib/WikibaseLib.hooks.php +++ b/lib/WikibaseLib.hooks.php @@ -30,18 +30,7 @@ */ public static function registerPhpUnitTests( array &$files ) { // @codeCoverageIgnoreStart - $directoryIterator = new RecursiveDirectoryIterator( __DIR__ . '/tests/phpunit/' ); - - /** - * @var SplFileInfo $fileInfo - */ - foreach ( new RecursiveIteratorIterator( $directoryIterator ) as $fileInfo ) { - if ( substr( $fileInfo->getFilename(), -8 ) === 'Test.php' ) { - $files[] = $fileInfo->getPathname(); - } - } - - return true; + $files[] = __DIR__ . '/tests/phpunit/'; // @codeCoverageIgnoreEnd } diff --git a/repo/Wikibase.hooks.php b/repo/Wikibase.hooks.php index 73307ce..54bee3b 100644 --- a/repo/Wikibase.hooks.php +++ b/repo/Wikibase.hooks.php @@ -164,18 +164,7 @@ */ public static function registerUnitTests( array &$files ) { // @codeCoverageIgnoreStart - $directoryIterator = new RecursiveDirectoryIterator( __DIR__ . '/tests/phpunit/' ); - - /** @var SplFileInfo $fileInfo */ - $ourFiles = array(); - foreach ( new RecursiveIteratorIterator( $directoryIterator ) as $fileInfo ) { - if ( substr( $fileInfo->getFilename(), -8 ) === 'Test.php' ) { - $ourFiles[] = $fileInfo->getPathname(); - } - } - - $files = array_merge( $files, $ourFiles ); - return true; + $files[] = __DIR__ . '/tests/phpunit/'; // @codeCoverageIgnoreEnd } -- To view, visit https://gerrit.wikimedia.org/r/188114 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd3a85751b2bb89df56889b0b0a4bcd6c98f41c7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Hoo man <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
