Ori.livneh has submitted this change and it was merged.

Change subject: Update navtiming reporter for latest schema
......................................................................


Update navtiming reporter for latest schema

Change-Id: Ib1c84aea8284dcb33576438213176b06d87f5da3
SCID: 10785754
SCID: 10785299
---
M modules/webperf/files/navtiming.py
1 file changed, 1 insertion(+), 9 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved



diff --git a/modules/webperf/files/navtiming.py 
b/modules/webperf/files/navtiming.py
index 338e76c..6a249a8 100644
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -59,9 +59,8 @@
 def handle_save_timing(meta):
     event = meta['event']
     duration = event['duration']
-    runtime = event['runtime']
     if is_sane(duration):
-        dispatch_stat('mw.performance.save', runtime, duration)
+        dispatch_stat('mw.performance.save', duration)
 
 
 @handles('NavigationTiming')
@@ -94,7 +93,6 @@
     site = 'mobile' if 'mobileMode' in event else 'desktop'
     auth = 'anonymous' if event.get('isAnon') else 'authenticated'
     https = 'https' if event.get('isHttps') else 'http'
-    runtime = event.get('runtime')
 
     # Current unused:
     bits_cache = meta.get('recvFrom', '').split('.')[0]
@@ -110,12 +108,6 @@
 
         if metric == 'connecting':
             dispatch_stat(prefix, metric, site, https, value)
-
-        if runtime:
-            # PHP5/HHVM-qualified metrics
-            dispatch_stat(prefix, runtime, metric, site, auth, value)
-            dispatch_stat(prefix, runtime, metric, site, 'overall', value)
-            dispatch_stat(prefix, runtime, metric, 'overall', value)
 
 
 for meta in iter(zsock.recv_json, ''):

-- 
To view, visit https://gerrit.wikimedia.org/r/188286
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1c84aea8284dcb33576438213176b06d87f5da3
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to