jenkins-bot has submitted this change and it was merged.
Change subject: Switch some handlers from on to once
......................................................................
Switch some handlers from on to once
Change-Id: If96da5e1e10d3918ef2537495e676679141d3426
---
M api/routes.js
M lib/mediawiki.parser.environment.js
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/api/routes.js b/api/routes.js
index cd6d61f..35c1eca 100644
--- a/api/routes.js
+++ b/api/routes.js
@@ -462,7 +462,7 @@
return new Promise(function( resolve, reject ) {
apiUtils.setHeader( res, env, 'Content-Type',
'text/plain; charset=UTF-8' );
apiUtils.sendResponse( res, env,
logData.fullMsg(), logData.flatLogObject().code || 500 );
- res.on( 'finish', resolve );
+ res.once( 'finish', resolve );
}).catch(function(e) {
console.error( e.stack || e );
res.end( e.stack || e );
diff --git a/lib/mediawiki.parser.environment.js
b/lib/mediawiki.parser.environment.js
index 081e65b..713ad50 100644
--- a/lib/mediawiki.parser.environment.js
+++ b/lib/mediawiki.parser.environment.js
@@ -332,7 +332,7 @@
cb( null );
} else if ( this.conf.parsoid.fetchConfig ) {
var confRequest = new ConfigRequest( uri, this,
this.getAPIProxy(prefix) );
- confRequest.on('src', setupWikiConfig.bind(null, this, uri));
+ confRequest.once('src', setupWikiConfig.bind(null, this, uri));
} else {
// Load the config from cached config on disk
var localConfigFile = './baseconfig/' + prefix + '.json',
--
To view, visit https://gerrit.wikimedia.org/r/188290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If96da5e1e10d3918ef2537495e676679141d3426
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
Gerrit-Reviewer: Marcoil <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
