Tobias Gritschacher has submitted this change and it was merged. Change subject: JS refactoring: Removing EditableValue reference from EditGroup ......................................................................
JS refactoring: Removing EditableValue reference from EditGroup Setting the EditGroup tooltip message in EditableValue finally allows removing the EditGroup's reference to EditableValue. - patch set 2: completely removed passing EditableValue in EditableValue and ...EditTool prototypes Change-Id: I430a01648b4689e4cd0b79cc67f819ab0af2823b --- M lib/resources/wikibase.ui.AliasesEditTool.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js M lib/resources/wikibase.ui.PropertyEditTool.js M lib/resources/wikibase.ui.SiteLinksEditTool.js M lib/resources/wikibase.ui.Toolbar.EditGroup.js M lib/tests/qunit/wikibase.ui.PropertyEditTool.EditableAliases.tests.js M lib/tests/qunit/wikibase.ui.PropertyEditTool.EditableDescription.tests.js M lib/tests/qunit/wikibase.ui.PropertyEditTool.EditableLabel.tests.js M lib/tests/qunit/wikibase.ui.PropertyEditTool.EditableSiteLink.tests.js M lib/tests/qunit/wikibase.ui.PropertyEditTool.EditableValue.tests.js M lib/tests/qunit/wikibase.ui.Toolbar.EditGroup.tests.js 11 files changed, 59 insertions(+), 49 deletions(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31856 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I430a01648b4689e4cd0b79cc67f819ab0af2823b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater <[email protected]> Gerrit-Reviewer: Henning Snater <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
