Marcoil has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/188336

Change subject: T88017: Remove data-parsoid.src
......................................................................

T88017: Remove data-parsoid.src

We don't need to keep the src for elements that have valid data-mw
and dsr.

Change-Id: Ife17d1d4f3300b84ec769363f15a141ae2bcfc6b
---
M lib/dom.cleanup.js
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/36/188336/1

diff --git a/lib/dom.cleanup.js b/lib/dom.cleanup.js
index dc170ca..2cb1f6f 100644
--- a/lib/dom.cleanup.js
+++ b/lib/dom.cleanup.js
@@ -63,12 +63,14 @@
                                DU.setDataMw(node, undefined);
                        }
 
-                       // Remove data-parsoid.src from templates and 
extensions that have
-                       // valid data-mw and dsr.  This should reduce 
data-parsoid bloat.
-                       //
+                       // Remove dp.src from elements that have valid data-mw 
and dsr. This
+                       // should reduce data-parsoid bloat.
+                       if (validDM && dp.dsr && dp.dsr[0] && dp.dsr[1]) {
+                               dp.src = undefined;
+                       }
                        // Transcluded nodes will not have dp.tsr set and dont 
need dp.src either
                        if 
(/(?:^|\s)mw:(Transclusion|Extension)(?=$|\s)/.test(node.getAttribute("typeof"))
 &&
-                               (!dp.tsr || validDM && dp.dsr && dp.dsr[0] && 
dp.dsr[1]))
+                               !dp.tsr)
                        {
                                dp.src = undefined;
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/188336
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife17d1d4f3300b84ec769363f15a141ae2bcfc6b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Marcoil <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to