Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188341
Change subject: Fix -> vs. > typo in DispatchStatsTest
......................................................................
Fix -> vs. > typo in DispatchStatsTest
This is crazy. How did this test ever succeeded? Is it even executed? However,
this is clearly a typo. A "greater than" comparison with undefined constants
doesn't make any sense here.
Change-Id: I11522d84b88811bdf3fe6aa8d315d18eb96598e9
---
M repo/tests/phpunit/includes/store/sql/DispatchStatsTest.php
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/41/188341/1
diff --git a/repo/tests/phpunit/includes/store/sql/DispatchStatsTest.php
b/repo/tests/phpunit/includes/store/sql/DispatchStatsTest.php
index 5097fe0..dad5e83 100644
--- a/repo/tests/phpunit/includes/store/sql/DispatchStatsTest.php
+++ b/repo/tests/phpunit/includes/store/sql/DispatchStatsTest.php
@@ -234,26 +234,26 @@
$this->assertInternalType( 'object', $actual );
if ( isset( $expected['site'] ) ) {
- $this->assertEquals( $expected['site'],
$actual>chd_site, 'site' );
+ $this->assertEquals( $expected['site'],
$actual->chd_site, 'site' );
$suffix = "/" . $expected['site'];
} else {
$suffix = '';
}
if ( isset( $expected['seen'] ) ) {
- $this->assertEquals( $expected['seen'],
$actual>chd_seen, "seen/$suffix" );
+ $this->assertEquals( $expected['seen'],
$actual->chd_seen, "seen/$suffix" );
}
if ( isset( $expected['touched'] ) ) {
- $this->assertEquals( $expected['touched'],
$actual>chd_touched, "touched/$suffix" );
+ $this->assertEquals( $expected['touched'],
$actual->chd_touched, "touched/$suffix" );
}
if ( isset( $expected['lag'] ) ) {
- $this->assertEquals( $expected['lag'],
$actual>chd_untouched, "lag/$suffix" );
+ $this->assertEquals( $expected['lag'],
$actual->chd_untouched, "lag/$suffix" );
}
if ( isset( $expected['dist'] ) ) {
- $this->assertEquals( $expected['dist'],
$actual>chd_pending, "dist/$suffix" );
+ $this->assertEquals( $expected['dist'],
$actual->chd_pending, "dist/$suffix" );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/188341
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11522d84b88811bdf3fe6aa8d315d18eb96598e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
