Jhernandez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188368
Change subject: Add arrow icon to read more in the collections view
......................................................................
Add arrow icon to read more in the collections view
** [FIXME] too big
Change-Id: If06b4094a87bb7bc74e098864f80a9a319c0555c
---
M i18n/en.json
A images/icons/next.svg
M includes/Resources.php
M includes/views/MobileCollectionItemCardView.php
4 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/68/188368/1
diff --git a/i18n/en.json b/i18n/en.json
index 7d4c936..e8f2e31 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -348,7 +348,7 @@
"mobile-frontend-watchlist-view": "View your watchlist",
"mobile-frontend-collection-watchlist-title": "My Watchlist",
"mobile-frontend-collection-watchlist-description": "Pages I watch
changes on.",
- "mobile-frontend-collection-read-more": "Read more…",
+ "mobile-frontend-collection-read-more": "Read more",
"mobile-frontend-collection-empty": "Nothing in this collection yet...",
"mobile-frontend-collection-empty-footer": "I don't know how you got
here but this is a sad place.",
"mobile.css": "/* CSS placed here will affect users of the mobile site
*/",
diff --git a/images/icons/next.svg b/images/icons/next.svg
new file mode 100644
index 0000000..5b2290e
--- /dev/null
+++ b/images/icons/next.svg
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 17.5 26"
enable-background="new 0 0 17.5 26">
+ <g>
+ <g>
+ <path fill="#347BFF" d="M4.6 24.3l-3.1-3 8.4-8.4-8.4-8.4 3.1-3L16
12.9z"/>
+ </g>
+ </g>
+</svg>
diff --git a/includes/Resources.php b/includes/Resources.php
index 0b980b2..80f72fd 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -120,6 +120,9 @@
// cite
'citation:before' => 'images/icons/cite.svg',
+
+ // collections
+ 'collections-read-more:after' =>
'images/icons/next.svg',
),
),
),
diff --git a/includes/views/MobileCollectionItemCardView.php
b/includes/views/MobileCollectionItemCardView.php
index 0eacfd5..b97569b 100644
--- a/includes/views/MobileCollectionItemCardView.php
+++ b/includes/views/MobileCollectionItemCardView.php
@@ -30,7 +30,10 @@
Html::element( 'a',
array(
'href' => $title->getLocalUrl(),
- 'class' => MobileUI::anchorClass(
'progressive' ),
+ 'class' => MobileUI::anchorClass(
+ 'progressive',
+ MobileUI::iconClass(
'collections-read-more', 'after' )
+ ),
),
wfMessage(
'mobile-frontend-collection-read-more' )
) .
--
To view, visit https://gerrit.wikimedia.org/r/188368
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If06b4094a87bb7bc74e098864f80a9a319c0555c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
