Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188622
Change subject: Hygiene: ImageOverlay should use View##events
......................................................................
Hygiene: ImageOverlay should use View##events
Bug: T88566
Change-Id: I1c2e4898bb5d27e0b9fb36feb88cf3ac57d045f7
---
M javascripts/modules/mediaViewer/ImageOverlay.js
1 file changed, 12 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/22/188622/1
diff --git a/javascripts/modules/mediaViewer/ImageOverlay.js
b/javascripts/modules/mediaViewer/ImageOverlay.js
index 1efd782..976ea00 100644
--- a/javascripts/modules/mediaViewer/ImageOverlay.js
+++ b/javascripts/modules/mediaViewer/ImageOverlay.js
@@ -42,6 +42,11 @@
},
/** @inheritdoc */
+ events: {
+ 'click .image-wrapper': 'onToggleDetails'
+ },
+
+ /** @inheritdoc */
preRender: function ( options ) {
var self = this;
$.each( options.thumbnails, function ( i, thumbnail ) {
@@ -106,11 +111,14 @@
} );
$( window ).on( 'resize', $.proxy( this,
'_positionImage' ) );
+ },
- this.$( '.image-wrapper' ).on( 'click', function () {
- self.$details.toggle();
- self._positionImage();
- } );
+ /**
+ * Event handler that toggles the details bar.
+ */
+ onToggleDetails: function() {
+ this.$details.toggle();
+ this._positionImage();
},
/** @inheritdoc */
--
To view, visit https://gerrit.wikimedia.org/r/188622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c2e4898bb5d27e0b9fb36feb88cf3ac57d045f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
