jenkins-bot has submitted this change and it was merged.
Change subject: Remove "Main Wiki Projects" empty field from review view
......................................................................
Remove "Main Wiki Projects" empty field from review view
Bug:T86980
Change-Id: Ia44093dd43905f6517d6c23cd3b650335d81cf5a
---
M data/i18n/en.json
M data/i18n/qqq.json
M data/templates/review/view.html
3 files changed, 3 insertions(+), 7 deletions(-)
Approvals:
BryanDavis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/data/i18n/en.json b/data/i18n/en.json
index 91e007f..6212254 100644
--- a/data/i18n/en.json
+++ b/data/i18n/en.json
@@ -269,9 +269,8 @@
"review-view-username": "Username:",
"review-view-alt-users": "Other usernames:",
"review-view-community": "Primary language community:",
- "review-view-active-projects": "Main Wiki Projects:",
- "review-view-primary-project": "Primary:",
- "review-view-secondary-project": "Secondary:",
+ "review-view-active-projects": "Main wiki project:",
+ "review-view-secondary-project": "Secondary wiki project:",
"review-view-previous-scholar": "Previous scholar?",
"review-view-attending-goals": "Previous experience and goals for
attending this year",
"review-view-involvement": "What have you built or contributed to in
order to improve your wiki or community? Have you lead or organized any of
these activities?",
diff --git a/data/i18n/qqq.json b/data/i18n/qqq.json
index 00ac99e..0ea6d58 100644
--- a/data/i18n/qqq.json
+++ b/data/i18n/qqq.json
@@ -241,7 +241,6 @@
"review-view-alt-users": "Report label",
"review-view-community": "Report label",
"review-view-active-projects": "Report label.\n{{Identical|Wiki}}",
- "review-view-primary-project": "Report label",
"review-view-secondary-project": "Report
label\n{{Identical|Secondary}}",
"review-view-previous-scholar": "Report label",
"review-view-attending-goals": "Report label",
diff --git a/data/templates/review/view.html b/data/templates/review/view.html
index a35833c..c479d98 100644
--- a/data/templates/review/view.html
+++ b/data/templates/review/view.html
@@ -107,10 +107,8 @@
<dt>{{ 'review-view-alt-users'|message }}</dt>
<dd>{{ schol.alt_users }}</dd>
{% endif %}
- <dt>{{ 'review-view-active-projects'|message }}</dt>
- <dd></dd>
{% if schol.project %}
- <dt>{{ 'review-view-primary-project'|message }}</dt>
+ <dt>{{ 'review-view-active-projects'|message }}</dt>
<dd>{{ schol.project }}</dd>
{% endif %}
{% if schol.project2 %}
--
To view, visit https://gerrit.wikimedia.org/r/185961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia44093dd43905f6517d6c23cd3b650335d81cf5a
Gerrit-PatchSet: 4
Gerrit-Project: wikimedia/wikimania-scholarships
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Niharika29 <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
