jenkins-bot has submitted this change and it was merged. Change subject: [BrowserTest] Simplify the Selenium selector for the Save button ......................................................................
[BrowserTest] Simplify the Selenium selector for the Save button The selector was very long and incorrect. This patch simplifies and corrects the selector. This also fixes the VisualEditor_save_dialog scenario in the language_screenshots scenarios. Change-Id: If822f1b2b8bda4d233dff5a88f6317ee1b0d57f1 --- M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb index 5b9a865..2a99dab 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb @@ -45,7 +45,7 @@ span(:decrease_indentation, class: 'oo-ui-iconElement-icon oo-ui-icon-outdent-list') text_area(:describe_change, index: 0) div(:diff_view, class: 've-ui-mwSaveDialog-viewer') - div(:disabled_save_button, class: 'oo-ui-widget oo-ui-widget-disabled oo-ui-buttonElement oo-ui-buttonElement-framed oo-ui-labelElement oo-ui-flaggedElement-constructive oo-ui-flaggedElement-primary oo-ui-buttonWidget ve-ui-toolbar-saveButton oo-ui-image-constructive') + div(:disabled_save_button, css: 'div.ve-init-mw-viewPageTarget-toolbar-actions > div.oo-ui-flaggedElement-progressive.oo-ui-widget-disabled') text_field(:display_title_textbox, css: 'div.oo-ui-fieldLayout-align-inline:nth-child(4) > label:nth-child(1) > div:nth-child(1) > div:nth-child(1) > input:nth-child(1)') text_field(:redirect_page_name_textbox, css: '.oo-ui-flaggedElement-invalid > input:nth-child(1)') span(:toolbar_format, css: '.ve-test-toolbar-format .oo-ui-indicator-down') -- To view, visit https://gerrit.wikimedia.org/r/186906 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If822f1b2b8bda4d233dff5a88f6317ee1b0d57f1 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Amire80 <[email protected]> Gerrit-Reviewer: Amire80 <[email protected]> Gerrit-Reviewer: Vikassy <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
