jenkins-bot has submitted this change and it was merged.
Change subject: Fix ClaimHtmlGenerator::getHtmlForClaim signature
......................................................................
Fix ClaimHtmlGenerator::getHtmlForClaim signature
Looks like the signature of the method changed but this mock did not.
This also adds some PHPDoc tags.
Change-Id: Id25c000f72471814d47c4a2688bc923450cc556b
---
M repo/tests/phpunit/includes/View/ClaimsViewTest.php
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Adrian Lang: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/includes/View/ClaimsViewTest.php
b/repo/tests/phpunit/includes/View/ClaimsViewTest.php
index 7811024..5097e0d 100644
--- a/repo/tests/phpunit/includes/View/ClaimsViewTest.php
+++ b/repo/tests/phpunit/includes/View/ClaimsViewTest.php
@@ -64,7 +64,7 @@
* @return Claim[]
*/
private function makeClaims( PropertyId $propertyId ) {
- $claims = array(
+ return array(
$this->makeClaim( new PropertyNoValueSnak(
$propertyId
) ),
@@ -88,8 +88,6 @@
new EntityIdValue( new ItemId( 'Q555' ) )
) ),
);
-
- return $claims;
}
/**
@@ -138,7 +136,7 @@
$claimHtmlGenerator->expects( $this->any() )
->method( 'getHtmlForClaim' )
- ->will( $this->returnCallback( function( Claim $claim,
$htmlForEditSection ) {
+ ->will( $this->returnCallback( function( Claim $claim,
$editSectionHtml = null ) {
return $claim->getGuid();
} ) );
--
To view, visit https://gerrit.wikimedia.org/r/186781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id25c000f72471814d47c4a2688bc923450cc556b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
