Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189142
Change subject: [BrowserTest] WIP make cite test pass
......................................................................
[BrowserTest] WIP make cite test pass
sleep is bad, figure out how to wait properly
Change-Id: I81bb01c77b3cf2695768ece2cd59d9a5e7593a93
---
M modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/42/189142/1
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
index c7ba872..7dc0baf 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
@@ -84,6 +84,7 @@
Then(/^diff view should show the Book citation added$/) do
on(VisualEditorPage) do |page|
+ sleep 1
page.wait_until(10) do
page.diff_view.include? 'Cite VisualEditor Test'
end
@@ -93,6 +94,7 @@
Then(/^diff view should show the Journal citation added$/) do
on(VisualEditorPage) do |page|
+ sleep 1
page.wait_until(10) do
page.diff_view.include? 'Cite VisualEditor Test'
end
@@ -102,6 +104,7 @@
Then(/^diff view should show the News citation added$/) do
on(VisualEditorPage) do |page|
+ sleep 1
page.wait_until(10) do
page.diff_view.include? 'Cite VisualEditor Test'
end
@@ -112,6 +115,7 @@
Then(/^diff view should show the Website citation added$/) do
on(VisualEditorPage) do |page|
page.wait_until(10) do
+ sleep 1
page.diff_view.include? 'Cite VisualEditor Test'
end
expect(page.diff_view).to match '<ref>{{Cite web|url =
http://en.wikipedia.org/|title = Website Source title|date = Website Source
date 28 July 2014|accessdate = {{CURRENTMONTHNAME}} {{CURRENTYEAR}}28 July
2014|website = Website title|publisher = Website publisher|last = Website Last
name|first = Website First name|New website field = New website field
contents}}</ref>Cite VisualEditor Test'
--
To view, visit https://gerrit.wikimedia.org/r/189142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81bb01c77b3cf2695768ece2cd59d9a5e7593a93
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
