Kaldari has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/189159

Change subject: Change 'original language of work' to 'original language' in 
WikiGrok
......................................................................

Change 'original language of work' to 'original language' in WikiGrok

Change-Id: Id927864733d58ac280f7f228bd6cac37d08e872c
---
M javascripts/modules/wikigrok/WikiGrokDialogB.js
1 file changed, 13 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/59/189159/1

diff --git a/javascripts/modules/wikigrok/WikiGrokDialogB.js 
b/javascripts/modules/wikigrok/WikiGrokDialogB.js
index b8ad899..e47d405 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialogB.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialogB.js
@@ -59,7 +59,18 @@
 
                                self.$( '.tags' ).show();
                                $.each( suggestions, function ( i, suggestion ) 
{
-                                       var $tag, tagHtml, templateData;
+                                       var $tag, tagHtml, templateData, 
propertyName;
+
+                                       // Replace some property names
+                                       // FIXME: These are not 
internationalizable and will probably have to
+                                       // die once WikiGrok is deployed 
outside of English Wikipedia
+                                       if ( suggestion.campaign.propertyName 
=== 'instance of' ) {
+                                               propertyName = 'type';
+                                       } else if ( 
suggestion.campaign.propertyName === 'original language of work' ) {
+                                               propertyName = 'original 
language';
+                                       } else {
+                                               propertyName = 
suggestion.campaign.propertyName;
+                                       }
 
                                        templateData = {
                                                id: 'tag-' + suggestion.id,
@@ -68,9 +79,7 @@
                                                itemId: suggestion.id,
                                                readable: suggestion.label,
                                                campaignName: 
suggestion.campaign.name,
-                                               // replace 'instance of' with 
'type'
-                                               campaignText: ( 
suggestion.campaign.propertyName === 'instance of' ) ?
-                                                       'type' : 
suggestion.campaign.propertyName,
+                                               campaignText: propertyName,
                                                tagText: suggestion.label
                                        };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/189159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id927864733d58ac280f7f228bd6cac37d08e872c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to