Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189198
Change subject: Escape messages on Special:Nuke
......................................................................
Escape messages on Special:Nuke
Bug: T85864
Change-Id: I194bb55c54791d5283c41c098a2fba15bcccb1bb
---
M Nuke_body.php
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Nuke
refs/changes/98/189198/1
diff --git a/Nuke_body.php b/Nuke_body.php
index 26ae386..1afc065 100644
--- a/Nuke_body.php
+++ b/Nuke_body.php
@@ -159,13 +159,14 @@
// Select: All, None
$links = array();
$links[] = '<a href="#" id="toggleall">' .
- $this->msg( 'powersearch-toggleall' )->text() . '</a>';
+ $this->msg( 'powersearch-toggleall' )->escaped() .
'</a>';
$links[] = '<a href="#" id="togglenone">' .
- $this->msg( 'powersearch-togglenone' )->text() . '</a>';
+ $this->msg( 'powersearch-togglenone' )->escaped() .
'</a>';
$out->addHTML(
Xml::tags( 'p',
null,
- $this->msg( 'nuke-select',
$this->getLanguage()->commaList( $links ) )->text()
+ $this->msg( 'nuke-select' )
+ ->rawParams(
$this->getLanguage()->commaList( $links ) )->escaped()
)
);
@@ -176,8 +177,8 @@
$out->addHTML( '<ul>' );
- $wordSeparator = $this->msg( 'word-separator' )->text();
- $commaSeparator = $this->msg( 'comma-separator' )->text();
+ $wordSeparator = $this->msg( 'word-separator' )->escaped();
+ $commaSeparator = $this->msg( 'comma-separator' )->escaped();
foreach ( $pages as $info ) {
/**
@@ -191,7 +192,7 @@
$userNameText = $userName ? $this->msg( 'nuke-editby',
$userName )->parse() . $commaSeparator : '';
$changesLink = Linker::linkKnown(
$title,
- $this->msg( 'nuke-viewchanges' )->text(),
+ $this->msg( 'nuke-viewchanges' )->escaped(),
array(),
array( 'action' => 'history' )
);
--
To view, visit https://gerrit.wikimedia.org/r/189198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I194bb55c54791d5283c41c098a2fba15bcccb1bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Nuke
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
