Mvolz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189207
Change subject: Bug T88897 Fix: Add popPending to error case
......................................................................
Bug T88897 Fix: Add popPending to error case
In the request to the citoid service, in case
of an error, make the dialog exit the pending
state.
Bug: T88887
Change-Id: I8959e09a5fc26fc1322944ed9d1d6878551e2333
---
M modules/ve.ui.CiteFromIDDialog.js
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Citoid
refs/changes/07/189207/1
diff --git a/modules/ve.ui.CiteFromIDDialog.js
b/modules/ve.ui.CiteFromIDDialog.js
index 85c6a4f..995ddf8 100644
--- a/modules/ve.ui.CiteFromIDDialog.js
+++ b/modules/ve.ui.CiteFromIDDialog.js
@@ -220,6 +220,7 @@
} else {
mw.notify( 'Status: '
+ textStatus + 'Error: ' + errorThrown );
}
+ dialog.popPending();
},
always: function () {
dialog.popPending();
--
To view, visit https://gerrit.wikimedia.org/r/189207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8959e09a5fc26fc1322944ed9d1d6878551e2333
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Mvolz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
