Cenarium has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189220
Change subject: Using different log entry for automatic review instead of
comment
......................................................................
Using different log entry for automatic review instead of comment
Automatic log entries now use a different message : review-logentry-app-auto,
similarly to
the patrol log. The revreview-auto message, which added an "(automatic)"
comment, is removed.
This prevents "((automatic))" log comments and authenticates the automatic
nature of the review.
Change-Id: I51963bea6d2686816b5ad8e86529d2237658b01f
---
M backend/FlaggedRevsLog.php
M frontend/FlaggedRevsUI.setup.php
M i18n/flaggedrevs/en.json
M i18n/flaggedrevs/qqq.json
4 files changed, 8 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/20/189220/1
diff --git a/backend/FlaggedRevsLog.php b/backend/FlaggedRevsLog.php
index a9ca3ea..70f6214 100644
--- a/backend/FlaggedRevsLog.php
+++ b/backend/FlaggedRevsLog.php
@@ -63,9 +63,6 @@
$isAuto = ( $auto && !FlaggedRevs::isQuality( $dims ) ); //
Paranoid check
// Approved revisions
if ( $approve ) {
- if ( $isAuto ) {
- $comment = wfMessage( 'revreview-auto'
)->inContentLanguage()->text(); // override this
- }
# Make comma-separated list of ratings
$rating = !empty( $ratings )
? '[' . implode( ', ', $ratings ) . ']'
diff --git a/frontend/FlaggedRevsUI.setup.php b/frontend/FlaggedRevsUI.setup.php
index da33d7f..262f010 100644
--- a/frontend/FlaggedRevsUI.setup.php
+++ b/frontend/FlaggedRevsUI.setup.php
@@ -221,10 +221,10 @@
$logActions['review/approve2'] = 'review-logentry-app'; //
quality (again)
$logActions['review/approve-i'] = 'review-logentry-app'; //
checked (first time)
$logActions['review/approve2-i'] = 'review-logentry-app'; //
quality (first time)
- $logActions['review/approve-a'] = 'review-logentry-app'; //
checked (auto)
- $logActions['review/approve2-a'] = 'review-logentry-app'; //
quality (auto)
- $logActions['review/approve-ia'] = 'review-logentry-app'; //
checked (initial & auto)
- $logActions['review/approve2-ia'] = 'review-logentry-app'; //
quality (initial & auto)
+ $logActions['review/approve-a'] = 'review-logentry-app-auto';
// checked (auto)
+ $logActions['review/approve2-a'] = 'review-logentry-app-auto';
// quality (auto)
+ $logActions['review/approve-ia'] = 'review-logentry-app-auto';
// checked (initial & auto)
+ $logActions['review/approve2-ia'] =
'review-logentry-app-auto'; // quality (initial & auto)
$logActions['review/unapprove'] = 'review-logentry-dis'; // was
checked
$logActions['review/unapprove2'] = 'review-logentry-dis'; //
was quality
diff --git a/i18n/flaggedrevs/en.json b/i18n/flaggedrevs/en.json
index bd7e1f3..fea4661 100644
--- a/i18n/flaggedrevs/en.json
+++ b/i18n/flaggedrevs/en.json
@@ -63,6 +63,7 @@
"revreview-log-details-title": "Toggle display of stability settings log",
"review-diff2stable": "View all pending changes",
"review-logentry-app": "reviewed a version of [[$1]]",
+ "review-logentry-app-auto": "automatically reviewed a version of [[$1]]",
"review-logentry-dis": "deprecated a version of [[$1]]",
"review-logentry-id": "revision: $2",
"review-logentry-diff": "changes reviewed",
@@ -76,7 +77,6 @@
"revreview-accuracy-2": "Accurate",
"revreview-accuracy-3": "Well sourced",
"revreview-accuracy-4": "Featured",
- "revreview-auto": "(automatic)",
"revreview-basic": "This is the [[{{MediaWiki:Validationpage}}|stable
version]], [{{fullurl:{{#Special:Log}}|type=review&page={{FULLPAGENAMEE}}}}
checked] on
<i>$2</i>.\n[{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur{{MediaWiki:flaggedrevs-diffonly}}}}
$3 pending {{PLURAL:$3|change|changes}}] {{PLURAL:$3|awaits|await}} review.",
"revreview-basic-i": "This is the [[{{MediaWiki:Validationpage}}|stable
version]], [{{fullurl:{{#Special:Log}}|type=review&page={{FULLPAGENAMEE}}}}
checked] on
<i>$2</i>.\n[{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur{{MediaWiki:flaggedrevs-diffonly}}}}
Template/file changes] await review.",
"revreview-basic-old": "This is a [[{{MediaWiki:Validationpage}}|checked]]
version ([{{fullurl:{{#Special:ReviewedVersions}}|page={{FULLPAGENAMEE}}}} list
all]), [{{fullurl:{{#Special:Log}}|type=review&page={{FULLPAGENAMEE}}}}
approved] on <i>$2</i>.\n\tNew
[{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur{{MediaWiki:flaggedrevs-diffonly}}}}
changes] may have been made.",
diff --git a/i18n/flaggedrevs/qqq.json b/i18n/flaggedrevs/qqq.json
index cc23338..4b553ee 100644
--- a/i18n/flaggedrevs/qqq.json
+++ b/i18n/flaggedrevs/qqq.json
@@ -1,4 +1,4 @@
-{
+{
"@metadata": {
"authors": [
"Aaron Schulz",
@@ -91,7 +91,8 @@
"revreview-log-details-hide": "{{Flagged Revs}}\nUsed as the name of a
toggle to collapse or collapse the stability log (see Special:Log/stable).
Shown on edit form for pages that show the stable version by default *but* only
for wikis were normally the latest revision is shown by
default.\n{{Identical|Hide details}}",
"revreview-log-details-title": "{{Flagged Revs}}\nUsed as the attribute
title of a toggle to collapse or uncollapse the stability log (see
Special:Log/stable)",
"review-diff2stable": "{{Flagged Revs}}\nShown at the top of diff forms
(in parenthesis) for pages with pending changes where the diff being viewed is
*not* the diff of the stable revision against the latest version.",
- "review-logentry-app": "{{Flagged Revs}}\nShown for review log entries
on Special:Log/review.\n\nSee example:
[[mw:Special:Log/review]].\n\nParameters:\n* $1 - a page
title\n{{Related|Review-logentry}}",
+ "review-logentry-app": "{{Flagged Revs}}\nShown for manual review log
entries on Special:Log/review.\n\nSee example:
[[mw:Special:Log/review]].\n\nParameters:\n* $1 - a page
title\n{{Related|Review-logentry}}",
+ "review-logentry-app-auto": "{{Flagged Revs}}\nShown for automatic
review log entries on Special:Log/review.\n\nSee example:
[[mw:Special:Log/review]].\n\nParameters:\n* $1 - a page
title\n{{Related|Review-logentry}}",
"review-logentry-dis": "{{Flagged Revs}}\nReview log entry on
Special:Log/review. Used when a previously stable or reviewed version's
review/stable tag has been removed, making the version deprecated.\n\nSee
example: [[mw:Special:Log/review]].\n\nParameters:\n* $1 - a page
title\n{{Related|Review-logentry}}",
"review-logentry-id": "{{Flagged Revs}}\nParameters:\n* $1 - (Unused)
revision ID\n* $2 - timestamp (time and date)\n{{Identical|Revision}}",
"review-logentry-diff": "{{Flagged Revs}}\nAppears at
Special:Log/review and is used for diff link text of log entries.\n\nThe diff
is between a revision that had been accepted and the previous accepted
revision.",
@@ -105,7 +106,6 @@
"revreview-accuracy-2": "{{Flagged Revs}}\nPossible value of the
'accuracy' tag for a revision. All accepted revisions must have ratings for
each tag type.\n{{Identical|Accurate}}",
"revreview-accuracy-3": "{{Flagged Revs}}\nPossible value of the
'accuracy' tag for a revision. All accepted revisions must have ratings for
each tag type.",
"revreview-accuracy-4": "{{Flagged Revs}}\nPossible value of the
'accuracy' tag for a revision. All accepted revisions must have ratings for
each tag type.\n{{Identical|Featured}}",
- "revreview-auto": "{{Flagged Revs}}\n{{Identical|Automatic}}",
"revreview-basic": "{{Flagged Revs}}\nShown when viewing the stable
version of a \"checked\" page when there are pending revisions.\n\nRefers to
{{msg-mw|Validationpage}} and
{{msg-mw|Flaggedrevs-diffonly}}.\n\nParameters:\n* $1 - stable revision ID\n*
$2 - the date of the approval\n* $3 - the number of pending edits
(revisions)\n{{Related|Revreview}}",
"revreview-basic-i": "{{Flagged Revs}}\nShown when viewing the stable
version of a \"checked\" page when only templates or files used in it have
pending revisions.\n\nRefers to {{msg-mw|Validationpage}} and
{{msg-mw|Flaggedrevs-diffonly}}.\n\nParameters:\n* $1 - stable revision ID\n*
$2 - the date of the approval\n* $3 - (Unused) the number of pending edits
(revisions)\n{{Related|Revreview}}",
"revreview-basic-old": "{{Flagged Revs}}\nShown when viewing an old
\"checked\" version of a page.\n\nRefers to {{msg-mw|Validationpage}} and
{{msg-mw|Flaggedrevs-diffonly}}.\n\nParameters:\n* $1 - stable revision ID\n*
$2 - date the stable version was accepted\nSee also:\n*
{{msg-mw|Revreview-quality-old}}",
--
To view, visit https://gerrit.wikimedia.org/r/189220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51963bea6d2686816b5ad8e86529d2237658b01f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Cenarium <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
