Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/189225

Change subject: Remove unnessecary link batch query
......................................................................

Remove unnessecary link batch query

Done in preQueryUsers, saves about 300 ms

Change-Id: I5339037345dcc944669a8c1343ae2e5694c7efa1
---
M specials/SpecialSupportedLanguages.php
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/25/189225/1

diff --git a/specials/SpecialSupportedLanguages.php 
b/specials/SpecialSupportedLanguages.php
index f31175a..6f075bb 100644
--- a/specials/SpecialSupportedLanguages.php
+++ b/specials/SpecialSupportedLanguages.php
@@ -265,7 +265,6 @@
                $res = $dbr->select( $tables, $vars, $conds, __METHOD__ );
 
                $users = array();
-               $lb = new LinkBatch;
                $lc = LinkCache::singleton();
 
                foreach ( $res as $row ) {
@@ -280,16 +279,12 @@
                        preg_match_all( '!{{[Uu]ser\|([^}|]+)!', $text, 
$matches, PREG_SET_ORDER );
                        foreach ( $matches as $match ) {
                                $user = Title::capitalize( $match[1], NS_USER );
-                               $lb->add( NS_USER, $user );
-                               $lb->add( NS_USER_TALK, $user );
                                if ( !isset( $users[$code] ) ) {
                                        $users[$code] = array();
                                }
                                $users[$code][strtr( $user, '_', ' ' )] = -1;
                        }
                }
-
-               $lb->execute();
 
                return $users;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/189225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5339037345dcc944669a8c1343ae2e5694c7efa1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to