jenkins-bot has submitted this change and it was merged.
Change subject: Fix wrong message lists in DetailsFormatters
......................................................................
Fix wrong message lists in DetailsFormatters
Copy-pasta, yea!
Change-Id: I9804986a4e5ae9f4cec3f87db0d34d39cdbdf8da
---
M lib/includes/formatters/GlobeCoordinateDetailsFormatter.php
M lib/includes/formatters/QuantityDetailsFormatter.php
M lib/includes/formatters/TimeDetailsFormatter.php
3 files changed, 17 insertions(+), 6 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/formatters/GlobeCoordinateDetailsFormatter.php
b/lib/includes/formatters/GlobeCoordinateDetailsFormatter.php
index a2ed6d8..6d277a5 100644
--- a/lib/includes/formatters/GlobeCoordinateDetailsFormatter.php
+++ b/lib/includes/formatters/GlobeCoordinateDetailsFormatter.php
@@ -107,8 +107,11 @@
protected function getFieldLabel( $fieldName ) {
$lang = $this->getOption( ValueFormatter::OPT_LANG );
- // Messages: wb-globedetails-amount, wb-globedetails-upperbound,
- // wb-globedetails-lowerbound, wb-globedetails-unit
+ // Messages:
+ // wikibase-globedetails-latitude
+ // wikibase-globedetails-longitude
+ // wikibase-globedetails-precision
+ // wikibase-globedetails-globe
$key = 'wikibase-globedetails-' . strtolower( $fieldName );
$msg = wfMessage( $key )->inLanguage( $lang );
diff --git a/lib/includes/formatters/QuantityDetailsFormatter.php
b/lib/includes/formatters/QuantityDetailsFormatter.php
index 7f2ca99..c0d6d14 100644
--- a/lib/includes/formatters/QuantityDetailsFormatter.php
+++ b/lib/includes/formatters/QuantityDetailsFormatter.php
@@ -106,8 +106,11 @@
protected function getFieldLabel( $fieldName ) {
$lang = $this->getOption( ValueFormatter::OPT_LANG );
- // Messages: wb-quantitydetails-amount,
wb-quantitydetails-upperbound,
- // wb-quantitydetails-lowerbound, wb-quantitydetails-unit
+ // Messages:
+ // wikibase-quantitydetails-amount
+ // wikibase-quantitydetails-upperbound
+ // wikibase-quantitydetails-lowerbound
+ // wikibase-quantitydetails-unit
$key = 'wikibase-quantitydetails-' . strtolower( $fieldName );
$msg = wfMessage( $key )->inLanguage( $lang );
diff --git a/lib/includes/formatters/TimeDetailsFormatter.php
b/lib/includes/formatters/TimeDetailsFormatter.php
index 5e5a021..1f1e888 100644
--- a/lib/includes/formatters/TimeDetailsFormatter.php
+++ b/lib/includes/formatters/TimeDetailsFormatter.php
@@ -115,8 +115,13 @@
protected function getFieldLabel( $fieldName ) {
$lang = $this->getOption( ValueFormatter::OPT_LANG );
- // Messages: wb-timedetails-amount, wb-timedetails-upperbound,
- // wb-timedetails-lowerbound, wb-timedetails-unit
+ // Messages:
+ // wikibase-timedetails-isotime
+ // wikibase-timedetails-timezone
+ // wikibase-timedetails-calendar
+ // wikibase-timedetails-precision
+ // wikibase-timedetails-before
+ // wikibase-timedetails-after
$key = 'wikibase-timedetails-' . strtolower( $fieldName );
$msg = wfMessage( $key )->inLanguage( $lang );
--
To view, visit https://gerrit.wikimedia.org/r/188536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9804986a4e5ae9f4cec3f87db0d34d39cdbdf8da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
