jenkins-bot has submitted this change and it was merged.
Change subject: Move style from JavaScript to CSS
......................................................................
Move style from JavaScript to CSS
Change-Id: I1bf4b886e3b9b789df377dbdd2df94eb80dd61d1
---
M modules/jquery.wikiEditor.dialogs.config.css
M modules/jquery.wikiEditor.dialogs.config.js
M modules/jquery.wikiEditor.dialogs.css
M modules/jquery.wikiEditor.toolbar.css
M modules/jquery.wikiEditor.toolbar.js
5 files changed, 15 insertions(+), 4 deletions(-)
Approvals:
GOIII: Looks good to me, but someone else must approve
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.wikiEditor.dialogs.config.css
b/modules/jquery.wikiEditor.dialogs.config.css
index 6b3edce..f34e7f0 100644
--- a/modules/jquery.wikiEditor.dialogs.config.css
+++ b/modules/jquery.wikiEditor.dialogs.config.css
@@ -2,6 +2,12 @@
* CSS for WikiEditor Dialogs
*/
+/* Replace Dialog */
+#wikieditor-toolbar-replace-search,
+#wikieditor-toolbar-replace-replace {
+ width: 100%;
+}
+
/* Table Dialog */
#wikieditor-toolbar-table-dialog fieldset {
width: 218px;
diff --git a/modules/jquery.wikiEditor.dialogs.config.js
b/modules/jquery.wikiEditor.dialogs.config.js
index f5d8af3..e593baf 100644
--- a/modules/jquery.wikiEditor.dialogs.config.js
+++ b/modules/jquery.wikiEditor.dialogs.config.js
@@ -1125,11 +1125,11 @@
<fieldset>\
<div
class="wikieditor-toolbar-field-wrapper">\
<label
for="wikieditor-toolbar-replace-search"
rel="wikieditor-toolbar-tool-replace-search"></label>\
- <input type="text"
id="wikieditor-toolbar-replace-search" style="width: 100%;"/>\
+ <input type="text"
id="wikieditor-toolbar-replace-search"/>\
</div>\
<div
class="wikieditor-toolbar-field-wrapper">\
<label
for="wikieditor-toolbar-replace-replace"
rel="wikieditor-toolbar-tool-replace-replace"></label>\
- <input type="text"
id="wikieditor-toolbar-replace-replace" style="width: 100%;"/>\
+ <input type="text"
id="wikieditor-toolbar-replace-replace"/>\
</div>\
<div
class="wikieditor-toolbar-field-wrapper">\
<input type="checkbox"
id="wikieditor-toolbar-replace-case"/>\
diff --git a/modules/jquery.wikiEditor.dialogs.css
b/modules/jquery.wikiEditor.dialogs.css
index 6d15f6a..942c66f 100644
--- a/modules/jquery.wikiEditor.dialogs.css
+++ b/modules/jquery.wikiEditor.dialogs.css
@@ -36,6 +36,7 @@
-ms-box-sizing: border-box;
-webkit-box-sizing: border-box;
-khtml-box-sizing: border-box;
+ box-sizing: border-box;
}
.wikiEditor-toolbar-dialog .ui-dialog-content input[type="radio"],
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 3148952..913ecc2 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -231,10 +231,14 @@
background-color: #FAFAFA;
}
/* Help Pages */
-.wikiEditor-ui-toolbar .page-table table {
+.wikiEditor-ui-toolbar .page-table {
padding-left: 5px;
padding-right: 5px;
+}
+.wikiEditor-ui-toolbar .page-table table {
background: none;
+ border-collapse: collapse;
+ width: 100%;
}
.wikiEditor-ui-toolbar .page-table th {
color: #999999;
diff --git a/modules/jquery.wikiEditor.toolbar.js
b/modules/jquery.wikiEditor.toolbar.js
index 53eb8a8..09f9e76 100644
--- a/modules/jquery.wikiEditor.toolbar.js
+++ b/modules/jquery.wikiEditor.toolbar.js
@@ -455,7 +455,7 @@
case 'table':
$page.addClass( 'page-table' );
html =
- '<table cellpadding=0 cellspacing=0 ' +
'border=0 width="100%" class="table table-' + id + '">';
+ '<table class="table-' + id + '">';
if ( 'headings' in page ) {
html +=
$.wikiEditor.modules.toolbar.fn.buildHeading( context, page.headings );
}
--
To view, visit https://gerrit.wikimedia.org/r/184846
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bf4b886e3b9b789df377dbdd2df94eb80dd61d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: GOIII <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
