Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189425
Change subject: Add extension.json and FIXME
......................................................................
Add extension.json and FIXME
Bug: T87909
Change-Id: I9e2e4a9088203bb286217bdfd6bac3c06f653815
---
M DynamicSidebar.body.php
M DynamicSidebar.php
A extension.json
3 files changed, 36 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DynamicSidebar
refs/changes/25/189425/1
diff --git a/DynamicSidebar.body.php b/DynamicSidebar.body.php
index a206dc2..fd6f0ca 100644
--- a/DynamicSidebar.body.php
+++ b/DynamicSidebar.body.php
@@ -9,6 +9,8 @@
// Don't pollute the sidebar cache for non-logged-in users
// Also ensure that logged-in users are getting dynamic content
// FIXME: Only do this for users who should actually get the
non-standard sidebar
+ // FIXME: Accessing $wgUser inside an extension function can
break depending on
+ // what other extensions are installed
if ( $wgUser->isLoggedIn() ) {
$wgEnableSidebarCache = false;
}
diff --git a/DynamicSidebar.php b/DynamicSidebar.php
index 7ace31e..a7cb902 100644
--- a/DynamicSidebar.php
+++ b/DynamicSidebar.php
@@ -47,7 +47,7 @@
'descriptionmsg' => 'dynamicsidebar-desc',
);
-$wgExtensionFunctions[] = array( 'DynamicSidebar', 'setup' );
+$wgExtensionFunctions[] = 'DynamicSidebar::setup';
$wgHooks['SkinBuildSidebar'][] = 'DynamicSidebar::modifySidebar';
$wgAutoloadClasses['DynamicSidebar'] = __DIR__ . '/DynamicSidebar.body.php';
diff --git a/extension.json b/extension.json
new file mode 100644
index 0000000..e343cb6
--- /dev/null
+++ b/extension.json
@@ -0,0 +1,33 @@
+{
+ "name": "DynamicSidebar",
+ "version": "1.1",
+ "author": "Ryan Lane",
+ "url": "https://www.mediawiki.org/wiki/Extension:DynamicSidebar";,
+ "descriptionmsg": "dynamicsidebar-desc",
+ "type": "other",
+ "config": {
+ "DynamicSidebarUseCategories": true,
+ "DynamicSidebarUseGroups": true,
+ "DynamicSidebarUsePageCategories": false,
+ "DynamicSidebarUseUserpages": true
+ },
+ "ExtensionMessagesFiles": {
+ "DynamicSidebar": "DynamicSidebar.i18n.php"
+ },
+ "Hooks": {
+ "SkinBuildSidebar": [
+ "DynamicSidebar::modifySidebar"
+ ]
+ },
+ "MessagesDirs": {
+ "DynamicSidebar": [
+ "i18n"
+ ]
+ },
+ "ExtensionFunctions": [
+ "DynamicSidebar::setup"
+ ],
+ "AutoloadClasses": {
+ "DynamicSidebar": "DynamicSidebar.body.php"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/189425
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e2e4a9088203bb286217bdfd6bac3c06f653815
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DynamicSidebar
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
