Rahdev has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189432
Change subject: Added feature to bring up W menu with a swipe gesture from the
left side of the screen
......................................................................
Added feature to bring up W menu with a swipe gesture from the left side of the
screen
Change-Id: Ib05a59cb1d4375b99d7a0c9db5da53f6be1cb4f6
Added feature to bring up W menu with a swipe gesture from the left side of
screen
Change-Id: I3ff017c644fa8b8abc34d4a2f6b6af63030183c5
---
M .gitreview
M Wikipedia.xcodeproj/project.pbxproj
A cocoapodsnotes.txt
M wikipedia/View Controllers/About/AboutViewController.plist
M wikipedia/View Controllers/Root/RootViewController.m
5 files changed, 45 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/32/189432/1
diff --git a/.gitreview b/.gitreview
index b4689ce..f907a1c 100644
--- a/.gitreview
+++ b/.gitreview
@@ -4,3 +4,4 @@
project=apps/ios/wikipedia.git
defaultbranch=master
defaultrebase=0
+defaultremote=origin
diff --git a/Wikipedia.xcodeproj/project.pbxproj
b/Wikipedia.xcodeproj/project.pbxproj
index 24cc092..a47ba5e 100644
--- a/Wikipedia.xcodeproj/project.pbxproj
+++ b/Wikipedia.xcodeproj/project.pbxproj
@@ -1856,7 +1856,7 @@
CreatedOnToolsVersion = 6.1.1;
};
D4991434181D51DE00E6073C = {
- DevelopmentTeam = AKK7J2GV64;
+ DevelopmentTeam = KEY5BBNC8Z;
};
};
};
diff --git a/cocoapodsnotes.txt b/cocoapodsnotes.txt
new file mode 100644
index 0000000..889e898
--- /dev/null
+++ b/cocoapodsnotes.txt
@@ -0,0 +1,37 @@
+
+Presently, the script "run-cocoapods.sh" calls "pod install --no-integrate"
+which causes the projects in "Podfile" to be downloaded and placed in the
+"Cocoapods/Pods/" directory. The needed source files were then dragged into
+the project manually.
+
+This is less than perfect, but the workspace file and other project
+integration which happens without the "--no-integrate" flag is still too
+messy. As Cocoapods approaches version 1.0 we can re-assess.
+
+Note: the "Cocoapods/Pods/" directory is wiped every time "run-cocoapods.sh"
+runs. So don't manually place any files in this directory.
+
+The "Podfile" may still be edited to include new Cocoapod dependencies,
+and they will be automatically downloaded on each time "run-cocoapods.sh"
+runs.
+
+When adding new library pods, they will appear automatically in the updated
+Pods.xcodeproj. But to make sure they are available to use in the main project:
+
+1) Go to the main target, 'Build Phases', and the relevant subprojects as
+ a 'target dependency'
+2) Add the subproject's .a output file to the linked libraries list
+3) Go back to 'Build Settings' and if necessary add a subdirectory to
+ the Headers path.
+
+Also note: the "run-cocoapods.sh" script only runs during a build if it
+is un-commented out: "Targets > Wikipedia > Build Phases" then expand the
+first "Run Script" entry and change "#scripts/run-cocoapods.sh" to
+"scripts/run-cocoapods.sh".
+
+To see if "run-cocoapods.sh" needs to be run, look at the versions specified
+in "Podfile" and compare these with the versions of each library available
+on http://cocoapods.org. If a newer version is available, update the
+"Podfile" version, then uncomment "run-cocoapods.sh" (as outlined above)
+and do a build so the build script runs. After running the build, re-comment
+"run-cocoapods.sh" (as outlined above).
diff --git a/wikipedia/View Controllers/About/AboutViewController.plist
b/wikipedia/View Controllers/About/AboutViewController.plist
index 813cd82..7f8dc9d 100644
--- a/wikipedia/View Controllers/About/AboutViewController.plist
+++ b/wikipedia/View Controllers/About/AboutViewController.plist
@@ -54,6 +54,7 @@
<string>Tomasz Finc</string>
<string>Vibha Bamba</string>
<string>Yuvi Panda</string>
+ <string>Raheem Raasikh</string>
</array>
</dict>
</plist>
diff --git a/wikipedia/View Controllers/Root/RootViewController.m
b/wikipedia/View Controllers/Root/RootViewController.m
index 2386b9e..8f57ada 100644
--- a/wikipedia/View Controllers/Root/RootViewController.m
+++ b/wikipedia/View Controllers/Root/RootViewController.m
@@ -49,6 +49,11 @@
// view appears and time onboarding vc's view appears - it's the briefest
// interval, but noticeable)
[self splashImageShow];
+
+ UIScreenEdgePanGestureRecognizer *screenEdgePanGesture =
[[UIScreenEdgePanGestureRecognizer alloc]initWithTarget:self
action:@selector(togglePrimaryMenu)];
+ screenEdgePanGesture.edges = UIRectEdgeLeft;
+
+ [self.view addGestureRecognizer: screenEdgePanGesture];
}
-(void)viewDidAppear:(BOOL)animated
--
To view, visit https://gerrit.wikimedia.org/r/189432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ff017c644fa8b8abc34d4a2f6b6af63030183c5
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Rahdev <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
