jenkins-bot has submitted this change and it was merged. Change subject: npm-set-env.sh: stop purging node_modules there ......................................................................
npm-set-env.sh: stop purging node_modules there Projects having a 'deploy' repository share a common job for their source code and deploy repos. For source repository we run npm install. When executing the tests, we want to load the env variables in npm-set-env.sh but need to keep the node_modules that have been previously set. The purging is being added directly in the Jenkins jobs before each npm install command: https://gerrit.wikimedia.org/r/189100 Change-Id: Iaa282f68f3f3d769402be3164b0a87e48518444a --- M bin/npm-set-env.sh 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: KartikMistry: Looks good to me, but someone else must approve Hashar: Looks good to me, approved jenkins-bot: Verified diff --git a/bin/npm-set-env.sh b/bin/npm-set-env.sh index 4b032c9..e5d51b1 100755 --- a/bin/npm-set-env.sh +++ b/bin/npm-set-env.sh @@ -13,6 +13,3 @@ # Set CHROME_BIN for projects using karma-chrome-launcher as our slaves have # Chromium instead of Chrome. export CHROME_BIN=`which chromium-browser` - -# Purge any existing node_modules. (T88395, T76304) -rm -rf node_modules -- To view, visit https://gerrit.wikimedia.org/r/189101 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa282f68f3f3d769402be3164b0a87e48518444a Gerrit-PatchSet: 2 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: KartikMistry <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
