Robert Vogel has submitted this change and it was merged.
Change subject: Review: Fixed wrong permission error
......................................................................
Review: Fixed wrong permission error
* Added "!" to expression
* I646154023bed3b88042bc8282abf57c1dc34529b
Change-Id: Ib9f9c4830b758df5e318845a3bfe4f88fbb3d391
---
M Review/Review.class.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Robert Vogel: Verified; Looks good to me, approved
diff --git a/Review/Review.class.php b/Review/Review.class.php
index 972867f..f51947a 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -1026,7 +1026,7 @@
if ($oTitle === false || !$oTitle->exists() || $oUser ===
false){
return wfMessage('bs-review-review-error')->plain();
}
- if ($oTitle->userCan("workflowview", $oUser)) {
+ if (!$oTitle->userCan("workflowview", $oUser)) {
return
wfMessage('bs-review-error-insufficient-permissions', 'workflowview')->text();
}
--
To view, visit https://gerrit.wikimedia.org/r/189445
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9f9c4830b758df5e318845a3bfe4f88fbb3d391
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: Pwirth <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pigpen <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
