jenkins-bot has submitted this change and it was merged.
Change subject: GlobalRenameQueue: Adjust sorting on /closed
......................................................................
GlobalRenameQueue: Adjust sorting on /closed
* Sort descending, so recently closed requests are on top
* Order by the closed timestamp instead of requested
Bug: T88886
Change-Id: I08991f986b8cb4ae9fd7ac8d0105ee4c40b51088
---
M includes/specials/SpecialGlobalRenameQueue.php
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
BryanDavis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialGlobalRenameQueue.php
b/includes/specials/SpecialGlobalRenameQueue.php
index f241c8e..0eeceb8 100644
--- a/includes/specials/SpecialGlobalRenameQueue.php
+++ b/includes/specials/SpecialGlobalRenameQueue.php
@@ -501,6 +501,11 @@
$this->mPage = $page;
$this->mDb = CentralAuthUser::getCentralSlaveDB();
$this->setLimit( 25 );
+ if ( $this->showOpenRequests() ) {
+ $this->mDefaultDirection = self::DIR_ASCENDING;
+ } else {
+ $this->mDefaultDirection = self::DIR_DESCENDING;
+ }
parent::__construct( $context );
}
@@ -636,7 +641,11 @@
* @return string
*/
public function getDefaultSort() {
- return 'rq_requested_ts';
+ if ( $this->showOpenRequests() ) {
+ return 'rq_requested_ts';
+ } else {
+ return 'rq_completed_ts';
+ }
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/189313
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08991f986b8cb4ae9fd7ac8d0105ee4c40b51088
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
