jenkins-bot has submitted this change and it was merged.
Change subject: Fix @return docs in WikibaseLuaBindings
......................................................................
Fix @return docs in WikibaseLuaBindings
Change-Id: Ie7d2ace89e02fa0569b823ff6efca3b0ccd48d45
---
M client/includes/scribunto/WikibaseLuaBindings.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/includes/scribunto/WikibaseLuaBindings.php
b/client/includes/scribunto/WikibaseLuaBindings.php
index c299976..fa647fc 100644
--- a/client/includes/scribunto/WikibaseLuaBindings.php
+++ b/client/includes/scribunto/WikibaseLuaBindings.php
@@ -122,7 +122,7 @@
* @param string $prefixedEntityId
*
* @since 0.5
- * @return string Empty string if entity couldn't be found/ no label
present
+ * @return string|null Null if entity couldn't be found/ no label
present
*/
public function getLabel( $prefixedEntityId ) {
try {
@@ -152,7 +152,7 @@
* @param string $prefixedEntityId
*
* @since 0.5
- * @return string Empty string if entity couldn't be found/ no sitelink
present
+ * @return string|null Null if entity couldn't be found/ no label
present
*/
public function getSiteLinkPageName( $prefixedEntityId ) {
try {
--
To view, visit https://gerrit.wikimedia.org/r/189325
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7d2ace89e02fa0569b823ff6efca3b0ccd48d45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
