Jeroen De Dauw has submitted this change and it was merged.

Change subject: Fix Bug 38811
......................................................................


Fix Bug 38811

Special:UnusedProperties was not checking if a property is special (pre-defined 
in SMW). This is fixed now, and thus the datatype information for unused 
special properties shows correctly and the standard tooltip is given. The 
formatting code for special properties is copied from Special:Properties, so 
the formatting will be the same as it is there.

The change depends on the recent updates done to fix Bug 33610.

Patch set 2: Also make a small change in the Proeprty datavalue to make sure 
that the CSS styles for highlighting special properties are really included 
whenever they are needed. Fixes the missing italics for special properties in 
all Special pages that list properties.

Change-Id: I0a49c1dae5e27ca12dd52e00fff6c3df1d0b006f
---
M includes/datavalues/SMW_DV_Property.php
M specials/QueryPages/SMW_SpecialUnusedProperties.php
2 files changed, 23 insertions(+), 13 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a49c1dae5e27ca12dd52e00fff6c3df1d0b006f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: Denny Vrandecic <[email protected]>
Gerrit-Reviewer: Foxtrott <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Kghbln <[email protected]>
Gerrit-Reviewer: Markus Kroetzsch <[email protected]>
Gerrit-Reviewer: Mwjames <[email protected]>
Gerrit-Reviewer: Nischayn22 <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to