Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189593
Change subject: Stop waiting for removed loading promise to finish
......................................................................
Stop waiting for removed loading promise to finish
In OOjs UI I2bfa013 the loading promise is removed since iframes were the ony
reason we needed it.
Change-Id: I1500f480d40d06e417366014b9c2a76f7ce9c29b
---
M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/93/189593/1
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
index c9af2a7..0b1cbe6 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
@@ -228,9 +228,7 @@
ve.ui.MWTemplateDialog.prototype.setApplicableStatus = function () {
var parts = this.transclusionModel && this.transclusionModel.getParts();
- if ( this.loading.state() !== 'resolved' ) {
- this.actions.setAbilities( { apply: false, insert: false } );
- } else if ( parts.length && !( parts[0] instanceof
ve.dm.MWTemplatePlaceholderModel ) ) {
+ if ( parts.length && !( parts[0] instanceof
ve.dm.MWTemplatePlaceholderModel ) ) {
this.actions.setAbilities( { apply: true, insert: true } );
} else {
this.actions.setAbilities( { apply: parts.length === 0, insert:
false } );
--
To view, visit https://gerrit.wikimedia.org/r/189593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1500f480d40d06e417366014b9c2a76f7ce9c29b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
