Yurik has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189619
Change subject: Properly HTML-escape banner text
......................................................................
Properly HTML-escape banner text
Change-Id: Ia6b7520a70fb830831aa2bad49d23adefbe6cc35
(cherry picked from commit d33441c9fd22f1fd5ad57e7f12f8749294f826e6)
---
M includes/ZeroSpecialPage.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroBanner
refs/changes/19/189619/1
diff --git a/includes/ZeroSpecialPage.php b/includes/ZeroSpecialPage.php
index 133f15c..0f9f431 100644
--- a/includes/ZeroSpecialPage.php
+++ b/includes/ZeroSpecialPage.php
@@ -413,7 +413,7 @@
// This request would have been
zero-rated if it was HTTP instead of HTTPS
// Hardcode colors here, easier
to treat as a banner
$banner =
-
PageRendering::makeBannerRaw( wfMessage( 'zero-no-https' )->text(),
+
PageRendering::makeBannerRaw( wfMessage( 'zero-no-https' )->escaped(),
'#000000',
'#DCDCDC', 'color:#000000;' );
$cfg =
PageRendering::getJsConfigBlock( $this, $xcs, $config, false, true );
}
--
To view, visit https://gerrit.wikimedia.org/r/189619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6b7520a70fb830831aa2bad49d23adefbe6cc35
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: wmf/1.25wmf15
Gerrit-Owner: Yurik <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
