Ryasmeen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189623
Change subject: [BrowserTest] Fix only Media Test The media test was passing
against garbage wikitext markup match. Fixed the steps so that it fails when it
should.
......................................................................
[BrowserTest] Fix only Media Test
The media test was passing against garbage wikitext markup match.
Fixed the steps so that it fails when it should.
Change-Id: I3d8dbc959c6244968dd9ac58af663b81cb115dc6
---
M modules/ve-mw/tests/browser/features/media_interface.feature
M modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb
2 files changed, 6 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/23/189623/1
diff --git a/modules/ve-mw/tests/browser/features/media_interface.feature
b/modules/ve-mw/tests/browser/features/media_interface.feature
index 52bb036..a83df71 100644
--- a/modules/ve-mw/tests/browser/features/media_interface.feature
+++ b/modules/ve-mw/tests/browser/features/media_interface.feature
@@ -13,8 +13,7 @@
And I click Insert
And I click Save page
And I click Review your changes
- Then <expected_markup_text> should appear in the media diff view
- And I can click the X on the media save box
+ Then diff view should show correct markup
Examples:
- | search_term | expected_markup_text
|
- | bug | [[File:Folgers.ogv\|thughmb]]
|
+ | search_term |
+ | bug |
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb
index d56b5c4..f019811 100644
---
a/modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb
+++
b/modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb
@@ -26,20 +26,11 @@
on(VisualEditorPage).media_insert_button_element.when_present.click
end
-Then(/^(.+) should appear in the media diff view$/) do |headings_string|
+Then(/^diff view should show correct markup$/) do
on(VisualEditorPage) do |page|
- # Contents pulled from the Cucumber tables in the .feature are escaped
regexes.
- # In this case we want unescaped regexes (and in one case a leading space)
- # So we put single quotes around the entries in the .feature file and
strip them here to get unescaped regexes.
- headings_string = headings_string.gsub(/'/, '')
page.wait_until(15) do
- sleep 1
- page.diff_view.include? 'Your text'
+ page.diff_view_element.exists?
end
- expect(page.diff_view).to match headings_string
+ expect(page.diff_view).to match /\[\[File:A Bug.JPG\|thumb\]\]/
end
-end
-
-Then(/^I can click the X on the media save box$/) do
- on(VisualEditorPage).media_exit_element.when_present.click
end
--
To view, visit https://gerrit.wikimedia.org/r/189623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d8dbc959c6244968dd9ac58af663b81cb115dc6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Ryasmeen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
