jenkins-bot has submitted this change and it was merged.
Change subject: Mobile: Fix JS-Exception for non-english beta projects
......................................................................
Mobile: Fix JS-Exception for non-english beta projects
Configs should always have a default value and other projects should benefit
from activated Wikidata features, too (otherwise it should be disabled by a
feature flag
instead of missing configuration).
Without a default value, the value is null, which results in a JS Exception when
the code tries to access the config as an array.
Bug: T89095
Bug: T88093
Change-Id: I36b62c084b17394ba8942a37f44d84dd26bf6faf
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
Hashar: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/wmf-config/InitialiseSettings-labs.php
b/wmf-config/InitialiseSettings-labs.php
index f0b8152..c596d67 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -263,16 +263,16 @@
'enwiki' => true,
),
'wmgMFWikiDataEndpoint' => array(
- 'enwiki' => 'http://wikidata.beta.wmflabs.org/w/api.php',
+ 'default' => 'http://wikidata.beta.wmflabs.org/w/api.php',
),
'wmgWikiBasePropertyConfig' => array(
- 'enwiki' => array(
+ 'default' => array(
'instanceOf' => 'P694',
'bannerImage' => 'P964',
),
),
'wmgMFInfoboxConfig' => array(
- 'enwiki' => array(
+ 'default' => array(
// human
5 => array(
'rows' => array(
--
To view, visit https://gerrit.wikimedia.org/r/189693
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36b62c084b17394ba8942a37f44d84dd26bf6faf
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Kaldari2 <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
