Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189735
Change subject: Remove <br> tags from special pages
......................................................................
Remove <br> tags from special pages
They are just not necesarry. All elements do have outer margins.
Please double check, e.g. with the MonoBook skin.
Change-Id: Ie1c3fb66f99b92044799838c8c86dc7ca991d85c
---
M repo/includes/specials/SpecialMergeItems.php
M repo/includes/specials/SpecialModifyEntity.php
M repo/includes/specials/SpecialModifyTerm.php
M repo/includes/specials/SpecialSetLabelDescriptionAliases.php
M repo/includes/specials/SpecialSetSiteLink.php
5 files changed, 6 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/35/189735/1
diff --git a/repo/includes/specials/SpecialMergeItems.php
b/repo/includes/specials/SpecialMergeItems.php
index 216b8cf..668d91f 100644
--- a/repo/includes/specials/SpecialMergeItems.php
+++ b/repo/includes/specials/SpecialMergeItems.php
@@ -294,7 +294,6 @@
'id' => 'wb-mergeitems-fromid'
)
)
- . Html::element( 'br' )
. Html::element(
'label',
array(
@@ -311,8 +310,7 @@
'class' => 'wb-input',
'id' => 'wb-mergeitems-toid'
)
- )
- . Html::element( 'br' );
+ );
// TODO: Selector for ignoreconflicts
}
diff --git a/repo/includes/specials/SpecialModifyEntity.php
b/repo/includes/specials/SpecialModifyEntity.php
index 54e76be..af0e8b2 100644
--- a/repo/includes/specials/SpecialModifyEntity.php
+++ b/repo/includes/specials/SpecialModifyEntity.php
@@ -239,8 +239,7 @@
'class' => 'wb-input',
'id' => 'wb-modifyentity-id'
)
- )
- . Html::element( 'br' );
+ );
}
/**
diff --git a/repo/includes/specials/SpecialModifyTerm.php
b/repo/includes/specials/SpecialModifyTerm.php
index b40ffe7..b40872c 100644
--- a/repo/includes/specials/SpecialModifyTerm.php
+++ b/repo/includes/specials/SpecialModifyTerm.php
@@ -206,8 +206,7 @@
'id' => 'wb-modifyterm-value',
'size' => 50
)
- )
- . Html::element( 'br' );
+ );
$languageName = Language::fetchLanguageName(
$this->languageCode, $this->getLanguage()->getCode() );
@@ -253,7 +252,6 @@
'id' => 'wb-modifyterm-language'
)
)
- . Html::element( 'br' )
. Html::element(
'label',
array(
diff --git a/repo/includes/specials/SpecialSetLabelDescriptionAliases.php
b/repo/includes/specials/SpecialSetLabelDescriptionAliases.php
index 9646694..dd68646 100644
--- a/repo/includes/specials/SpecialSetLabelDescriptionAliases.php
+++ b/repo/includes/specials/SpecialSetLabelDescriptionAliases.php
@@ -204,8 +204,7 @@
'id' => 'wikibase-setlabeldescriptionaliases-'
. $name,
'size' => 50
)
- )
- . Html::element( 'br' );
+ );
}
/**
@@ -215,8 +214,7 @@
* @return string
*/
private function getLabel( $name ) {
- return Html::element( 'br' )
- . Html::element(
+ return Html::element(
$name,
array(
'for' => 'wikibase-setlabeldescriptionaliases-'
. $name,
diff --git a/repo/includes/specials/SpecialSetSiteLink.php
b/repo/includes/specials/SpecialSetSiteLink.php
index 095c0a2..ac9fc1f 100644
--- a/repo/includes/specials/SpecialSetSiteLink.php
+++ b/repo/includes/specials/SpecialSetSiteLink.php
@@ -226,8 +226,7 @@
);
if ( !empty( $this->badgeItems ) ) {
- $pageinput .= Html::element( 'br' )
- . Html::element(
+ $pageinput .= Html::element(
'label',
array(
'class' => 'wb-label'
@@ -284,7 +283,6 @@
'id' => 'wb-setsitelink-site'
)
)
- . Html::element( 'br' )
. $pageinput;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/189735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1c3fb66f99b92044799838c8c86dc7ca991d85c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
