Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189742
Change subject: Specific type hints in LabelDescriptionUniquenessValidatorTest
......................................................................
Specific type hints in LabelDescriptionUniquenessValidatorTest
Change-Id: Ia53c3ce5e9aca163d190c9f2f984b5bdfa29a55f
---
M
repo/tests/phpunit/includes/Validators/LabelDescriptionUniquenessValidatorTest.php
1 file changed, 4 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/42/189742/1
diff --git
a/repo/tests/phpunit/includes/Validators/LabelDescriptionUniquenessValidatorTest.php
b/repo/tests/phpunit/includes/Validators/LabelDescriptionUniquenessValidatorTest.php
index 45e5223..7836a29 100644
---
a/repo/tests/phpunit/includes/Validators/LabelDescriptionUniquenessValidatorTest.php
+++
b/repo/tests/phpunit/includes/Validators/LabelDescriptionUniquenessValidatorTest.php
@@ -79,12 +79,11 @@
);
}
- private function fingerprintCaseToEntityCase( $fingerprintCase, $id ) {
+ private function fingerprintCaseToEntityCase( array $fingerprintCase,
ItemId $id ) {
$fingerprint = reset( $fingerprintCase );
- $item = Item::newEmpty();
+ $item = new Item( $id );
$item->setFingerprint( $fingerprint );
- $item->setId( $id );
$entityCase = $fingerprintCase;
$entityCase[0] = $item;
@@ -107,7 +106,7 @@
// check validation without entity id
$cases["no id"] = array(
- Item::newEmpty(),
+ new Item(),
);
return $cases;
@@ -115,7 +114,6 @@
/**
* @dataProvider validEntityProvider
- *
* @param Entity $entity
*/
public function testValidateEntity( Entity $entity ) {
@@ -129,10 +127,9 @@
/**
* @dataProvider validFingerprintProvider
- *
* @param Fingerprint $fingerprint
* @param EntityId $entityId
- * @param array $languageCodes
+ * @param array|null $languageCodes
*/
public function testValidateFingerprint(
Fingerprint $fingerprint,
@@ -173,7 +170,6 @@
/**
* @dataProvider invalidEntityProvider
- *
* @param Entity $entity
* @param string|null $error
*/
@@ -191,7 +187,6 @@
/**
* @dataProvider invalidFingerprintProvider
- *
* @param Fingerprint $fingerprint
* @param string|null $error
*/
--
To view, visit https://gerrit.wikimedia.org/r/189742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia53c3ce5e9aca163d190c9f2f984b5bdfa29a55f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
