Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189751
Change subject: ListToolGroup: Remove hack for jQuery's .show()/.hide()
......................................................................
ListToolGroup: Remove hack for jQuery's .show()/.hide()
No longer needed after we switched to using the .oo-ui-element-hidden
class in c762da42.
Bug: T89073
Change-Id: If4f9db6f9dc453e3ef9c7b46872c87ce00b4ae68
---
M src/toolgroups/ListToolGroup.js
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/51/189751/1
diff --git a/src/toolgroups/ListToolGroup.js b/src/toolgroups/ListToolGroup.js
index a7854c3..f9c823c 100644
--- a/src/toolgroups/ListToolGroup.js
+++ b/src/toolgroups/ListToolGroup.js
@@ -72,14 +72,6 @@
this.$group.append( this.getExpandCollapseTool().$element );
this.getExpandCollapseTool().toggle( this.collapsibleTools.length !== 0
);
-
- // Calling jQuery's .hide() and then .show() on a detached element
caches the default value of its
- // 'display' attribute and restores it, and the tool uses a <span> and
can be hidden and re-shown.
- // Is this a jQuery bug? http://jsfiddle.net/gtj4hu3h/
- if ( this.getExpandCollapseTool().$element.css( 'display' ) ===
'inline' ) {
- this.getExpandCollapseTool().$element.css( 'display', 'block' );
- }
-
this.updateCollapsibleState();
};
--
To view, visit https://gerrit.wikimedia.org/r/189751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4f9db6f9dc453e3ef9c7b46872c87ce00b4ae68
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
