Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189839
Change subject: Remove obvious function-level profiling
......................................................................
Remove obvious function-level profiling
Change-Id: I2270b936a1502df07f0dae529b0180908c70c58a
---
M BaseBlacklist.php
M SpamBlacklist_body.php
2 files changed, 1 insertion(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SpamBlacklist
refs/changes/39/189839/1
diff --git a/BaseBlacklist.php b/BaseBlacklist.php
index ea5c7d9..b1958c3 100644
--- a/BaseBlacklist.php
+++ b/BaseBlacklist.php
@@ -223,15 +223,12 @@
function getSharedBlacklists() {
global $wgMemc, $wgDBname;
$listType = $this->getBlacklistType();
- $fname = 'SpamBlacklist::getRegex';
- wfProfileIn( $fname );
wfDebugLog( 'SpamBlacklist', "Loading $listType regex..." );
if ( count( $this->files ) == 0 ){
# No lists
wfDebugLog( 'SpamBlacklist', "no files specified\n" );
- wfProfileOut( $fname );
return array();
}
@@ -240,7 +237,6 @@
$cachedRegexes = $wgMemc->get(
"$wgDBname:{$listType}_blacklist_regexes" );
if( is_array( $cachedRegexes ) ) {
wfDebugLog( 'SpamBlacklist', "Got shared spam regexes
from cache\n" );
- wfProfileOut( $fname );
return $cachedRegexes;
}
diff --git a/SpamBlacklist_body.php b/SpamBlacklist_body.php
index 19f69ac..8c270f4 100644
--- a/SpamBlacklist_body.php
+++ b/SpamBlacklist_body.php
@@ -41,9 +41,6 @@
* @return Array Matched text(s) if the edit should not be allowed,
false otherwise
*/
function filter( array $links, Title $title = null, $preventLog = false
) {
- $fname = 'wfSpamBlacklistFilter';
- wfProfileIn( $fname );
-
$blacklists = $this->getBlacklists();
$whitelists = $this->getWhitelists();
@@ -114,7 +111,7 @@
} else {
$retVal = false;
}
- wfProfileOut( $fname );
+
return $retVal;
}
--
To view, visit https://gerrit.wikimedia.org/r/189839
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2270b936a1502df07f0dae529b0180908c70c58a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SpamBlacklist
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
