jenkins-bot has submitted this change and it was merged.
Change subject: Simplify CXSourceSelector.prototype.checkForTitle with .then()
......................................................................
Simplify CXSourceSelector.prototype.checkForTitle with .then()
Change-Id: Iafd6515caea46e60e046f3c5e488a2c66731fe33
---
M modules/source/ext.cx.source.selector.js
1 file changed, 8 insertions(+), 15 deletions(-)
Approvals:
Santhosh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/source/ext.cx.source.selector.js
b/modules/source/ext.cx.source.selector.js
index f7b9295..4b5bec9 100644
--- a/modules/source/ext.cx.source.selector.js
+++ b/modules/source/ext.cx.source.selector.js
@@ -458,10 +458,9 @@
* @return {jQuery.promise}
*/
CXSourceSelector.prototype.checkForTitle = function ( language, title )
{
- var api = this.siteMapper.getApi( language ),
- $deferred = $.Deferred();
+ var api = this.siteMapper.getApi( language );
- api.get( {
+ return api.get( {
action: 'opensearch',
search: title,
namespace: 0,
@@ -471,19 +470,13 @@
dataType: 'jsonp',
// This prevents warnings about the unrecognized
parameter "_"
cache: true
- } )
- .done( function ( response ) {
- if ( response[ 1 ][ 0 ] === title ) {
- $deferred.resolve( title );
- } else {
- $deferred.resolve( false );
- }
- } )
- .fail( function () {
- $deferred.resolve( false );
- } );
+ } ).then( function ( response ) {
+ if ( response[ 1 ][ 0 ] === title ) {
+ return title;
+ }
- return $deferred.promise();
+ return false;
+ } );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/189691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafd6515caea46e60e046f3c5e488a2c66731fe33
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Jsahleen <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
