Prtksxna has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189940
Change subject: MediaWiki Theme: Rename active-* classes to pressed-*
......................................................................
MediaWiki Theme: Rename active-* classes to pressed-*
The active-color and active-text variables were mostly being used
in -pressed classes. They have been grouped in the variables file
and replaced everywhere.
The selectWidget-depressed uses this color, not sure if its an
implementation or design error.
Change-Id: I66885a6271646b8763498b69639687e241969d15
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
M src/themes/mediawiki/widgets.less
3 files changed, 9 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/40/189940/1
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 466c6b8..0b82798 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -20,7 +20,8 @@
@disabled-destructive: darken( @destructive, @disabled-percentage );
@text: #757575;
-@active-text: #444444;
+@pressed-text: #444444;
+@pressed-color: #d0d0d0; // Used for borders and backgrounds
@disabled-text: #eeeeee;
@disabled-framed-text: #ffffff;
@disabled-background: #eeeeee;
@@ -45,8 +46,6 @@
@input-focus-border-width: 2px;
@input-size: 1.6em;
@border-radius: 2px;
-
-@active-color: #d0d0d0;
// Theme mixins
diff --git a/src/themes/mediawiki/elements.less
b/src/themes/mediawiki/elements.less
index 1184ee9..62a973a 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -56,7 +56,7 @@
}
&.oo-ui-buttonElement-pressed >
.oo-ui-buttonElement-button > .oo-ui-labelElement-label {
- color: @active-text;
+ color: @pressed-text;
}
&.oo-ui-flaggedElement {
@@ -139,8 +139,8 @@
& > .oo-ui-buttonElement-button:active,
&.oo-ui-buttonElement-pressed >
.oo-ui-buttonElement-button {
- background-color: @active-color;
- border-color: @active-color;
+ background-color: @pressed-color;
+ border-color: @pressed-color;
box-shadow: none;
}
@@ -221,7 +221,7 @@
.oo-ui-buttonElement-button:active,
&.oo-ui-buttonElement-pressed > .oo-ui-buttonElement-button {
color: @pressed;
- border-color: @active-color;
+ border-color: @pressed-color;
box-shadow: none;
}
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index a67d6b1..2ca158e 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -517,7 +517,7 @@
.oo-ui-selectWidget-pressed &-pressed,
.oo-ui-selectWidget-pressed &-pressed&-highlighted,
.oo-ui-selectWidget-pressed &-pressed&-highlighted&-selected {
- background-color: @active-color;
+ background-color: @pressed-color;
}
&.oo-ui-widget-disabled {
@@ -637,7 +637,7 @@
}
.oo-ui-selectWidget-depressed &.oo-ui-optionWidget-selected {
- background-color: @active-color;
+ background-color: @pressed-color;
text-shadow: 0 1px 1px #fff;
}
@@ -862,7 +862,7 @@
&.oo-ui-toggleWidget-on {
.oo-ui-toggleSwitchWidget-glow {
- background-color: @active-color;
+ background-color: @pressed-color;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/189940
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66885a6271646b8763498b69639687e241969d15
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
