Prtksxna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/189939

Change subject: MediaWiki Theme: Rename @active to @pressed in button mixins
......................................................................

MediaWiki Theme: Rename @active to @pressed in button mixins

This color is used for the -pressed and :hover classes. The -active
class is used for the current highlighted element (like a button in
a group) and shouldn't be confused with :active.

Change-Id: Ia41938dd172537935bd9bd12389692089fd206e3
---
M src/themes/mediawiki/elements.less
1 file changed, 15 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/39/189939/1

diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index ed18ea8..1184ee9 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -179,7 +179,7 @@
        }
 }
 
-.mediawiki-frameless-button-colored( @neutral, @active ) {
+.mediawiki-frameless-button-colored( @neutral, @pressed ) {
        > .oo-ui-buttonElement-button {
                &:hover,
                &:focus {
@@ -196,31 +196,31 @@
        &.oo-ui-widget-enabled {
                & > .oo-ui-buttonElement-button:active > 
.oo-ui-labelElement-label,
                &.oo-ui-buttonElement-pressed > .oo-ui-buttonElement-button > 
.oo-ui-labelElement-label {
-                       color: @active;
+                       color: @pressed;
                        box-shadow: none;
                }
        }
 }
 
-.mediawiki-framed-button-colored( @neutral, @active ) {
+.mediawiki-framed-button-colored( @neutral, @pressed ) {
        > .oo-ui-buttonElement-button {
                color: @neutral;
 
                &:hover {
-                       box-shadow: inset 0 -0.2em 0 0 @active, 0 0.1em 0 0 
rgba(0,0,0,0.1);
-                       border-bottom-color: @active;
+                       box-shadow: inset 0 -0.2em 0 0 @pressed, 0 0.1em 0 0 
rgba(0,0,0,0.1);
+                       border-bottom-color: @pressed;
                }
 
                &:focus {
-                       box-shadow: inset 0 0 0 1px @active;
-                       border-color: @active;
+                       box-shadow: inset 0 0 0 1px @pressed;
+                       border-color: @pressed;
                }
        }
 
        &.oo-ui-widget-enabled {
                .oo-ui-buttonElement-button:active,
                &.oo-ui-buttonElement-pressed > .oo-ui-buttonElement-button {
-                       color: @active;
+                       color: @pressed;
                        border-color: @active-color;
                        box-shadow: none;
                }
@@ -232,20 +232,20 @@
        }
 }
 
-.mediawiki-framed-primary-button-colored( @neutral, @active ) {
+.mediawiki-framed-primary-button-colored( @neutral, @pressed ) {
        > .oo-ui-buttonElement-button {
                color: @background;
                background-color: @neutral;
                border-color: @neutral;
 
                &:hover {
-                       box-shadow: inset 0 -0.2em 0 0 @active, 0 0.1em 0 0 
rgba(0,0,0,0.1);
-                       border-bottom-color: @active;
+                       box-shadow: inset 0 -0.2em 0 0 @pressed, 0 0.1em 0 0 
rgba(0,0,0,0.1);
+                       border-bottom-color: @pressed;
                }
 
                &:focus {
-                       box-shadow: inset 0 0 0 1px @active;
-                       border-color: @active;
+                       box-shadow: inset 0 0 0 1px @pressed;
+                       border-color: @pressed;
                }
        }
 
@@ -253,8 +253,8 @@
                .oo-ui-buttonElement-button:active,
                &.oo-ui-buttonElement-pressed > .oo-ui-buttonElement-button {
                        color: @background;
-                       background-color: @active;
-                       border-color: @active;
+                       background-color: @pressed;
+                       border-color: @pressed;
                        box-shadow: none;
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/189939
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia41938dd172537935bd9bd12389692089fd206e3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to