Prtksxna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/189945

Change subject: MediaWiki Theme: Use white icons for disabled buttons
......................................................................

MediaWiki Theme: Use white icons for disabled buttons

Bug: T88483
Change-Id: I9f7e3df13a8c0793441274cb90c40514b7d8302d
---
M src/themes/mediawiki/MediaWikiTheme.js
M src/themes/mediawiki/elements.less
2 files changed, 3 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/45/189945/1

diff --git a/src/themes/mediawiki/MediaWikiTheme.js 
b/src/themes/mediawiki/MediaWikiTheme.js
index cb2ce56..86ec8e4 100644
--- a/src/themes/mediawiki/MediaWikiTheme.js
+++ b/src/themes/mediawiki/MediaWikiTheme.js
@@ -31,7 +31,9 @@
                classes = 
OO.ui.MediaWikiTheme.super.prototype.getElementClasses.call( this, element );
 
        if ( element.supports( [ 'isFramed', 'isDisabled', 'hasFlag' ] ) ) {
-               if ( !element.isDisabled() && element.isFramed() && 
element.hasFlag( 'primary' ) ) {
+               if ( ( !element.isDisabled() && element.isFramed() && 
element.hasFlag( 'primary' ) ) ||
+                       element.isDisabled()
+               ) {
                        variants.invert = true;
                } else {
                        variants.progressive = element.hasFlag( 'progressive' );
diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index ed18ea8..4c98b4c 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -27,13 +27,6 @@
                height: 1.9em;
        }
 
-       &.oo-ui-widget-disabled > .oo-ui-buttonElement-button {
-               > .oo-ui-iconElement-icon,
-               > .oo-ui-indicatorElement-indicator {
-                       opacity: 0.2;
-               }
-       }
-
        &-frameless {
                > .oo-ui-buttonElement-button {
                        &:hover,

-- 
To view, visit https://gerrit.wikimedia.org/r/189945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f7e3df13a8c0793441274cb90c40514b7d8302d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to