Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189950
Change subject: MenuSelectWidget: Don't clobber other events when unbinding
......................................................................
MenuSelectWidget: Don't clobber other events when unbinding
Only unbind our event rather than everything.
Change-Id: Id9f9241a40adfae0760daed141693e85dbdc677f
---
M src/widgets/MenuSelectWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/50/189950/1
diff --git a/src/widgets/MenuSelectWidget.js b/src/widgets/MenuSelectWidget.js
index f399342..bfe0ea1 100644
--- a/src/widgets/MenuSelectWidget.js
+++ b/src/widgets/MenuSelectWidget.js
@@ -135,7 +135,7 @@
*/
OO.ui.MenuSelectWidget.prototype.unbindKeyDownListener = function () {
if ( this.$input ) {
- this.$input.off( 'keydown' );
+ this.$input.off( 'keydown', this.onKeyDownHandler );
} else {
this.getElementWindow().removeEventListener( 'keydown',
this.onKeyDownHandler, true );
}
--
To view, visit https://gerrit.wikimedia.org/r/189950
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9f9241a40adfae0760daed141693e85dbdc677f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
