Alexandros Kosiaris has submitted this change and it was merged.

Change subject: add chromium-admins to visual editor role
......................................................................


add chromium-admins to visual editor role

Add the newly created chromium-admin group (I96d07556ecaafd)
to the Visual Editor role class, so that it gets applied on osmium
and resolves the access request for Roan in T89038.

Bug:T89038
Change-Id: I4b1c4625b335dbef6cba4c1fab6091b71142c625
---
A hieradata/role/common/ve.yaml
M manifests/site.pp
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Alexandros Kosiaris: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/hieradata/role/common/ve.yaml b/hieradata/role/common/ve.yaml
new file mode 100644
index 0000000..7bddf05a
--- /dev/null
+++ b/hieradata/role/common/ve.yaml
@@ -0,0 +1,2 @@
+admin::groups:
+  - chromium-admin
diff --git a/manifests/site.pp b/manifests/site.pp
index ce761a5..c226390 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1993,7 +1993,7 @@
 # VisualEditor performance testing rig
 node 'osmium.eqiad.wmnet' {
     include ::standard
-    include ::role::ve
+    role ve
 }
 
 # base_analytics_logging_node is defined in role/logging.pp

-- 
To view, visit https://gerrit.wikimedia.org/r/189611
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b1c4625b335dbef6cba4c1fab6091b71142c625
Gerrit-PatchSet: 6
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Andrew Bogott <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: RobH <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to