Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190255
Change subject: [BrowserTest] Remove unused steps and locators
......................................................................
[BrowserTest] Remove unused steps and locators
No more iframes
Change-Id: I3d6420f2a017a132d5695921daa5efb5117f3176
---
M
modules/ve-mw/tests/browser/features/step_definitions/multiedit_workflow_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/references_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
3 files changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/55/190255/1
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/multiedit_workflow_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/multiedit_workflow_steps.rb
index 07500de..262fd08 100644
---
a/modules/ve-mw/tests/browser/features/step_definitions/multiedit_workflow_steps.rb
+++
b/modules/ve-mw/tests/browser/features/step_definitions/multiedit_workflow_steps.rb
@@ -22,10 +22,6 @@
on(VisualEditorPage).content_element.when_present(10).send_keys(input_string)
end
-When(/^I click Save page another time$/) do
- on(VisualEditorPage).another_save_page_element.when_present.click
-end
-
Then(/^the saved page should contain all three edits\.$/) do
expect(on(VisualEditorPage).page_text_element.when_present(10).text).to
match "#{@third_edit_text}#{@second_edit_text}Editing with #{@random_string}
#{@first_edit_text}"
end
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/references_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/references_steps.rb
index 061ad9b..6296fa1 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/references_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/references_steps.rb
@@ -24,13 +24,6 @@
end
end
-When(/^I enter (.+) into Content box$/) do |content|
- on(VisualEditorPage) do |page|
- page.content_box_element.when_present
- page.content_box_element.send_keys(content)
- end
-end
-
When(/^I click use an existing reference button in References User
Interface$/) do
on(VisualEditorPage).cite_reuse_existing_reference_element.when_present.click
end
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 20b0f8d..346b6ba 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -181,7 +181,6 @@
text_area(:formula_area, css: '.oo-ui-popupWidget-popup textarea')
in_iframe(index: 0) do |frame|
- span(:another_save_page, class: 'oo-ui-labelElement-label', text: 'Save
page', frame: frame)
div(:content_box, class: 've-ce-documentNode ve-ce-branchNode', frame:
frame) # ALSO USED IN LANGUAGE SCREENSHOT
# USED IN LANGUAGE SCREENSHOT TEST:
--
To view, visit https://gerrit.wikimedia.org/r/190255
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d6420f2a017a132d5695921daa5efb5117f3176
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
