jenkins-bot has submitted this change and it was merged.
Change subject: Use node type constants in ve.ce.getDomHash
......................................................................
Use node type constants in ve.ce.getDomHash
Change-Id: I814baa0b5ba005332271d0ae0a37284ef647d59b
---
M src/ce/ve.ce.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.js b/src/ce/ve.ce.js
index ab87dd9..0d4e0a2 100644
--- a/src/ce/ve.ce.js
+++ b/src/ce/ve.ce.js
@@ -108,9 +108,9 @@
nodeName = element.nodeName,
hash = '';
- if ( nodeType === 3 || nodeType === 4 ) {
+ if ( nodeType === Node.TEXT_NODE || nodeType ===
Node.CDATA_SECTION_NODE ) {
return '#';
- } else if ( nodeType === 1 || nodeType === 9 ) {
+ } else if ( nodeType === Node.ELEMENT_NODE || nodeType ===
Node.DOCUMENT_NODE ) {
hash += '<' + nodeName + '>';
// Traverse its children
for ( element = element.firstChild; element; element =
element.nextSibling ) {
--
To view, visit https://gerrit.wikimedia.org/r/189967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I814baa0b5ba005332271d0ae0a37284ef647d59b
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
