Robmoen has submitted this change and it was merged.
Change subject: Hygiene: Rename UserNotFound to NotFound
......................................................................
Hygiene: Rename UserNotFound to NotFound
Because it is actually a not found page and it is used in a few places for
that.
Change-Id: I72cae4cf49366127b17878f1758448aed78be0a4
---
M Gather.php
M includes/specials/SpecialGather.php
R includes/views/NotFound.php
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Robmoen: Verified; Looks good to me, approved
diff --git a/Gather.php b/Gather.php
index 2f74012..0520a90 100644
--- a/Gather.php
+++ b/Gather.php
@@ -53,7 +53,7 @@
'Gather\stores\ItemImages' => 'stores/ItemImages',
'Gather\views\View' => 'views/View',
- 'Gather\views\UserNotFound' => 'views/UserNotFound',
+ 'Gather\views\NotFound' => 'views/NotFound',
'Gather\views\Collection' => 'views/Collection',
'Gather\views\CollectionItemCard' => 'views/CollectionItemCard',
'Gather\views\ItemImage' => 'views/ItemImage',
diff --git a/includes/specials/SpecialGather.php
b/includes/specials/SpecialGather.php
index 7e56a37..b97de75 100644
--- a/includes/specials/SpecialGather.php
+++ b/includes/specials/SpecialGather.php
@@ -45,7 +45,7 @@
if ( !( $user && $user->getId() ) ) {
// Invalid user
- $this->renderUserNotFoundError();
+ $this->renderNotFoundError();
} else {
if ( isset( $args ) && isset( $args[1] ) ) {
$id = $args[1];
@@ -59,8 +59,8 @@
/**
* Render an error when the user was not found
*/
- public function renderUserNotFoundError() {
- $this->render( new views\UserNotFound() );
+ public function renderNotFoundError() {
+ $this->render( new views\NotFound() );
}
/**
diff --git a/includes/views/UserNotFound.php b/includes/views/NotFound.php
similarity index 92%
rename from includes/views/UserNotFound.php
rename to includes/views/NotFound.php
index 7ffb616..6c5819b 100644
--- a/includes/views/UserNotFound.php
+++ b/includes/views/NotFound.php
@@ -1,6 +1,6 @@
<?php
/**
- * UserNotFound.php
+ * NotFound.php
*/
namespace Gather\views;
@@ -10,7 +10,7 @@
/**
* Renders an error when the user wasn't found
*/
-class UserNotFound extends View {
+class NotFound extends View {
/**
* @inheritdoc
--
To view, visit https://gerrit.wikimedia.org/r/190259
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72cae4cf49366127b17878f1758448aed78be0a4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
