Jeroen De Dauw has submitted this change and it was merged.
Change subject: Inline trivial ApiWikibase::formatSummary method
......................................................................
Inline trivial ApiWikibase::formatSummary method
I assume this method is there because it was way more complicated
before. But it uses a service now and is super-trivial.
Additionally it's used only a single time.
This is split from Ic506adc.
Change-Id: Id5a272f0cf4689ff56708ff5f451e73dd63c8d9d
---
M repo/includes/api/ApiWikibase.php
1 file changed, 1 insertion(+), 11 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
diff --git a/repo/includes/api/ApiWikibase.php
b/repo/includes/api/ApiWikibase.php
index c463dc7..ed45145 100644
--- a/repo/includes/api/ApiWikibase.php
+++ b/repo/includes/api/ApiWikibase.php
@@ -387,7 +387,7 @@
}
if ( $summary instanceof Summary ) {
- $summary = $this->formatSummary( $summary );
+ $summary = $this->summaryFormatter->formatSummary(
$summary );
}
$params = $this->extractRequestParams();
@@ -449,16 +449,6 @@
$baseRevisionId = $baseRevisionId > 0 ? $baseRevisionId : false;
return $baseRevisionId;
- }
-
- /**
- * @param Summary $summary
- *
- * @return string
- */
- protected function formatSummary( Summary $summary ) {
- $formatter = $this->summaryFormatter;
- return $formatter->formatSummary( $summary );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/189932
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5a272f0cf4689ff56708ff5f451e73dd63c8d9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
