jenkins-bot has submitted this change and it was merged.
Change subject: Fix spammy "Writes done" debug message
......................................................................
Fix spammy "Writes done" debug message
Was broken by I1a8830eaf, which accidentally caused the log message to
be output for every write query, instead of only the first write query.
Change-Id: I4a53914bcb28804ff4c31b4e0418591793d411b6
---
M includes/db/Database.php
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/db/Database.php b/includes/db/Database.php
index 896b621..538facb 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -1083,8 +1083,11 @@
$isWriteQuery = $this->isWriteQuery( $sql );
if ( $isWriteQuery ) {
+ if ( !$this->mDoneWrites ) {
+ wfDebug( __METHOD__ . ': Writes done: ' .
+ DatabaseBase::generalizeSQL( $sql ) .
"\n" );
+ }
# Set a flag indicating that writes have been done
- wfDebug( __METHOD__ . ': Writes done: ' .
DatabaseBase::generalizeSQL( $sql ) . "\n" );
$this->mDoneWrites = microtime( true );
}
--
To view, visit https://gerrit.wikimedia.org/r/190414
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a53914bcb28804ff4c31b4e0418591793d411b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
