Christopher Johnson (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190418
Change subject: minor scutinizer and lint fixes
......................................................................
minor scutinizer and lint fixes
Change-Id: I076b54192f7979b1a4b35d36e19e3185ba214aad
---
M src/storage/SprintColumnTransaction.php
M src/storage/TaskTableDataProvider.php
M src/view/SprintListTableView.php
M src/view/SprintTableView.php
M src/view/burndown/BoardDataPieView.php
M src/view/burndown/BoardDataTableView.php
M src/view/burndown/TasksTableView.php
M src/view/reports/SprintReportOpenTasksView.php
8 files changed, 21 insertions(+), 22 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/Sprint
refs/changes/18/190418/1
diff --git a/src/storage/SprintColumnTransaction.php
b/src/storage/SprintColumnTransaction.php
index 6651507..a347036 100644
--- a/src/storage/SprintColumnTransaction.php
+++ b/src/storage/SprintColumnTransaction.php
@@ -41,7 +41,7 @@
return $xactions;
}
- public function parseEvents($dates, $xactions) {
+ public function parseEvents($dates) {
$sprintpoints = id(new SprintPoints())
->setTaskPoints($this->taskpoints);
@@ -57,12 +57,10 @@
switch ($event['type']) {
case 'close':
- // A task was closed, mark it as done
$this->closeTasksToday($date, $dates);
$this->closePointsToday($date, $points, $dates);
break;
case 'reopen':
- // A task was reopened, subtract from done
$this->reopenedTasksToday($date, $dates);
$this->reopenedPointsToday($date, $points, $dates);
break;
diff --git a/src/storage/TaskTableDataProvider.php
b/src/storage/TaskTableDataProvider.php
index 9eaf90e..ff5528b 100644
--- a/src/storage/TaskTableDataProvider.php
+++ b/src/storage/TaskTableDataProvider.php
@@ -102,7 +102,8 @@
$rows = array();
foreach ($this->tasks as $task) {
$this->blocked = $this->checkForBlocked($task, $map);
- list ($this->blocker, $this->ptasks) = $this->checkForBlocker($task,
$map);
+ list ($this->blocker, $this->ptasks) = $this->checkForBlocker($task,
+ $map);
$this->points = $sprintpoints->getTaskPoints($task->getPHID());
$row = $this->addTaskToTree($task);
diff --git a/src/view/SprintListTableView.php b/src/view/SprintListTableView.php
index bec262f..cfb4d8c 100644
--- a/src/view/SprintListTableView.php
+++ b/src/view/SprintListTableView.php
@@ -2,10 +2,10 @@
final class SprintListTableView {
- private $table_data;
+ private $tableData;
public function setTableData ($table_data) {
- $this->table_data = $table_data;
+ $this->tableData = $table_data;
return $this;
}
@@ -14,7 +14,7 @@
Javelin::initBehavior('sprint-table', array(
'hardpoint' => $id,
), 'sprint');
- $projects_table = id(new SprintTableView($this->table_data->getRows()))
+ $projects_table = id(new SprintTableView($this->tableData->getRows()))
->setHeaders(
array(
'Sprint Name',
diff --git a/src/view/SprintTableView.php b/src/view/SprintTableView.php
index 001ad70..1e560a8 100644
--- a/src/view/SprintTableView.php
+++ b/src/view/SprintTableView.php
@@ -36,8 +36,8 @@
return $this;
}
- public function setTableId($tableId) {
- $this->tableId = $tableId;
+ public function setTableId($table_id) {
+ $this->tableId = $table_id;
return $this;
}
diff --git a/src/view/burndown/BoardDataPieView.php
b/src/view/burndown/BoardDataPieView.php
index aaf8701..b10ede7 100644
--- a/src/view/burndown/BoardDataPieView.php
+++ b/src/view/burndown/BoardDataPieView.php
@@ -2,17 +2,17 @@
final class BoardDataPieView {
- private $board_data;
+ private $boardData;
public function setBoardData ($board_data) {
- $this->board_data = $board_data;
+ $this->boardData = $board_data;
return $this;
}
public function buildPieBox() {
$this->initBoardDataPie();
$this->initTaskStatusPie();
- $project_name = $this->board_data->getProject()->getName();
+ $project_name = $this->boardData->getProject()->getName();
$boardpie = phutil_tag('div',
array(
'id' => 'c3-board-data-pie',
@@ -37,7 +37,7 @@
require_celerity_resource('c3-css', 'sprint');
require_celerity_resource('c3', 'sprint');
- $coldata = $this->board_data->getColumnData();
+ $coldata = $this->boardData->getColumnData();
$done_points = '0';
$backlog_points = '0';
$doing_points = '0';
@@ -74,8 +74,8 @@
private function initTaskStatusPie() {
$sprintpoints = id(new SprintPoints())
- ->setTaskPoints($this->board_data->getTaskPoints())
- ->setTasks($this->board_data->getTasks());
+ ->setTaskPoints($this->boardData->getTaskPoints())
+ ->setTasks($this->boardData->getTasks());
list($task_open_status_sum, $task_closed_status_sum) = $sprintpoints
->getStatusSums();
diff --git a/src/view/burndown/BoardDataTableView.php
b/src/view/burndown/BoardDataTableView.php
index 9379f64..50f046d 100644
--- a/src/view/burndown/BoardDataTableView.php
+++ b/src/view/burndown/BoardDataTableView.php
@@ -2,15 +2,15 @@
final class BoardDataTableView {
- private $board_data;
+ private $boardData;
public function setBoardData ($board_data) {
- $this->board_data = $board_data;
+ $this->boardData = $board_data;
return $this;
}
public function buildBoardDataTable() {
- $coldata = $this->board_data->getColumnData();
+ $coldata = $this->boardData->getColumnData();
$table = id(new AphrontTableView($coldata))
->setHeaders(
array(
diff --git a/src/view/burndown/TasksTableView.php
b/src/view/burndown/TasksTableView.php
index b37adb0..3eaeabc 100644
--- a/src/view/burndown/TasksTableView.php
+++ b/src/view/burndown/TasksTableView.php
@@ -2,11 +2,11 @@
final class TasksTableView {
- private $table_data;
+ private $tableData;
public function setTableData ($table_data) {
- $this->table_data = $table_data;
+ $this->tableData = $table_data;
return $this;
}
@@ -18,7 +18,7 @@
public function buildTasksTable() {
Javelin::initBehavior('tasks-table', array(
), 'sprint');
- $table = id(new SprintTableView($this->table_data->getRows()))
+ $table = id(new SprintTableView($this->tableData->getRows()))
->setHeaders(
array(
pht('Task'),
diff --git a/src/view/reports/SprintReportOpenTasksView.php
b/src/view/reports/SprintReportOpenTasksView.php
index 7df607f..c0b2ee0 100644
--- a/src/view/reports/SprintReportOpenTasksView.php
+++ b/src/view/reports/SprintReportOpenTasksView.php
@@ -95,7 +95,7 @@
if ($project_handle) {
$tokens = array($project_handle);
}
- $filter = parent::renderReportFilters($tokens, $has_window = false,
+ $filter = $this->renderReportFilters($tokens, $has_window = false,
$this->request, $this->user);
return array($filter, $panel);
--
To view, visit https://gerrit.wikimedia.org/r/190418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I076b54192f7979b1a4b35d36e19e3185ba214aad
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
