jenkins-bot has submitted this change and it was merged.
Change subject: Avoid duplicate code in TestChanges
......................................................................
Avoid duplicate code in TestChanges
Change-Id: Ibdcc546c2a5765d2d4de98684adfe0acb421b742
---
M lib/tests/phpunit/changes/TestChanges.php
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/tests/phpunit/changes/TestChanges.php
b/lib/tests/phpunit/changes/TestChanges.php
index fcadf65..95e8429 100644
--- a/lib/tests/phpunit/changes/TestChanges.php
+++ b/lib/tests/phpunit/changes/TestChanges.php
@@ -36,14 +36,17 @@
final class TestChanges {
protected static function getItem() {
- $item = Item::newEmpty();
- $item->getFingerprint()->setLabel( 'en', 'Venezuela' );
- $item->getFingerprint()->setDescription( 'en', 'a country' );
- $item->getFingerprint()->setAliasGroup( 'en', array(
'Bolivarian Republic of Venezuela' ) );
+ $item = new Item();
- $item->getSiteLinkList()->addNewSiteLink( 'enwiki', 'Venezuela'
);
- $item->getSiteLinkList()->addNewSiteLink( 'jawiki', 'ベネズエラ' );
- $item->getSiteLinkList()->addNewSiteLink( 'cawiki', 'Veneçuela'
);
+ $fingerprint = $item->getFingerprint();
+ $fingerprint->setLabel( 'en', 'Venezuela' );
+ $fingerprint->setDescription( 'en', 'a country' );
+ $fingerprint->setAliasGroup( 'en', array( 'Bolivarian Republic
of Venezuela' ) );
+
+ $siteLinks = $item->getSiteLinkList();
+ $siteLinks->addNewSiteLink( 'enwiki', 'Venezuela' );
+ $siteLinks->addNewSiteLink( 'jawiki', 'ベネズエラ' );
+ $siteLinks->addNewSiteLink( 'cawiki', 'Veneçuela' );
return $item;
}
--
To view, visit https://gerrit.wikimedia.org/r/189743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdcc546c2a5765d2d4de98684adfe0acb421b742
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
