[MediaWiki-commits] [Gerrit] Fix JSHint warnings (aka warnings from the Timo on my shoulder) - change (mediawiki...OOUIPlayground)

[Jforrester (Code Review)]

Jforrester has submitted this change and it was merged.

Change subject: Fix JSHint warnings (aka warnings from the Timo on my shoulder)
......................................................................


Fix JSHint warnings (aka warnings from the Timo on my shoulder)

Change-Id: I7eeb2a962a835f125d9295f393571e77a70b8ca4
---
M resources/defer.js
1 file changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  Jforrester: Verified



diff --git a/resources/defer.js b/resources/defer.js
index f73ea4c..a2476ae 100644
--- a/resources/defer.js
+++ b/resources/defer.js
@@ -1,4 +1,5 @@
-(function( $, mw ) {
+/* global OO */
+(function( $, OO ) {
 $( function() {
        function instantiateFromParameters( config ) {
                var className = config['class'],
@@ -10,10 +11,10 @@
                                .text( 'Unable to load ' + className );
                }
 
-               if ( config['items'] ) {
+               if ( config.items ) {
                        newItems = [];
-                       $.each( config['items'], function( index, item ) {
-                               newItem = instantiateFromParameters( item );
+                       $.each( config.items, function( index, item ) {
+                               var newItem = instantiateFromParameters( item );
 
                                if ( newItem.$element ) {
                                        // A proper OOUI
@@ -23,7 +24,7 @@
                                }
                        } );
 
-                       config['items'] = newItems;
+                       config.items = newItems;
                }
 
                // Pass out errors
@@ -32,7 +33,7 @@
                }
 
                if ( className === 'FieldLayout' ) {
-                       return new OO.ui[className]( config['items'].shift(), 
config );
+                       return new OO.ui[className]( config.items.shift(), 
config );
                } else {
                        return new OO.ui[className]( config );
                }
@@ -49,4 +50,4 @@
                }
        } );
 } );
-})( jQuery, mediaWiki );
\ No newline at end of file
+})( jQuery, OO );

-- 
To view, visit https://gerrit.wikimedia.org/r/187727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7eeb2a962a835f125d9295f393571e77a70b8ca4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OOUIPlayground
Gerrit-Branch: master
Gerrit-Owner: Werdna <agarr...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits