Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190570
Change subject: [BREAKING CHANGE] TextInputWidget: Remove 'icon' and
'indicator' events
......................................................................
[BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events
Change-Id: Iba8deeb7bf94984832c658b2a5710d1f833472c0
---
M src/widgets/TextInputWidget.js
1 file changed, 0 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/70/190570/1
diff --git a/src/widgets/TextInputWidget.js b/src/widgets/TextInputWidget.js
index db87ad3..b28931f 100644
--- a/src/widgets/TextInputWidget.js
+++ b/src/widgets/TextInputWidget.js
@@ -113,22 +113,6 @@
* @event enter
*/
-/**
- * User clicks the icon.
- *
- * @deprecated Fundamentally not accessible. Make the icon focusable,
associate a label or tooltip,
- * and handle click/keypress events on it manually.
- * @event icon
- */
-
-/**
- * User clicks the indicator.
- *
- * @deprecated Fundamentally not accessible. Make the indicator focusable,
associate a label or
- * tooltip, and handle click/keypress events on it manually.
- * @event indicator
- */
-
/* Methods */
/**
@@ -140,7 +124,6 @@
OO.ui.TextInputWidget.prototype.onIconMouseDown = function ( e ) {
if ( e.which === 1 ) {
this.$input[ 0 ].focus();
- this.emit( 'icon' );
return false;
}
};
@@ -154,7 +137,6 @@
OO.ui.TextInputWidget.prototype.onIndicatorMouseDown = function ( e ) {
if ( e.which === 1 ) {
this.$input[ 0 ].focus();
- this.emit( 'indicator' );
return false;
}
};
--
To view, visit https://gerrit.wikimedia.org/r/190570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba8deeb7bf94984832c658b2a5710d1f833472c0
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
